Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix project id undefined error by disabling when not in project #1131

Merged

Conversation

naman1608
Copy link
Contributor

@naman1608 naman1608 commented Jun 6, 2024

What does this PR do?

In the search options, the security and the settings section were not clickable as the callback functions were referencing project.$id which is undefined when the page url is not that of a project. Added condition to disable these options based on whether project.$id exists or not.

Fixes #1042

Test Plan

(Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work.)

Related PRs and Issues

Have you read the Contributing Guidelines on issues?

(Write your answer here.)

Copy link

vercel bot commented Jun 6, 2024

@naman1608 is attempting to deploy a commit to the appwrite Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

vercel bot commented Jun 8, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
console-billing ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 8, 2024 0:37am
console-cloud ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 8, 2024 0:37am
console-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 8, 2024 0:37am
console-preview-cloud ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 8, 2024 0:37am

Copy link
Contributor

@stnguyen90 stnguyen90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Before:

image

After:

image

@stnguyen90 stnguyen90 merged commit e1169fa into appwrite:main Jun 8, 2024
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 Bug Report: Some items in the search dialog don't work
2 participants