Update #597
Merged
Update #597
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
In my opinion, removing breaks is a bit pointless, because yes the code is more readable with breaks, updating packages yes it makes sense, but removing breaks in the code in my opinion does not measure up, because the code becomes less readable by its continuous sequence. |
Signed-off-by: LucasB25 <50886682+LucasB25@users.noreply.github.com>
Signed-off-by: LucasB25 <50886682+LucasB25@users.noreply.github.com>
Signed-off-by: LucasB25 <50886682+LucasB25@users.noreply.github.com>
Signed-off-by: LucasB25 <50886682+LucasB25@users.noreply.github.com>
|
I have to agree with @infnibor here even though this PR was already merged. I don't think it provides an actual increase in quality to this project. Removing empty lines can be helpful, but it wasn't in this case. It removed logical breaks between two statements and that across over 80 files in the entire codebase. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are no errors now, but I may have made a mistake cleaning up the code.