Fix scheduling week N #92
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We incorrectly returned an error in the helper function `CheckIsoWeek` if ISO week `N` did not match current week. This PR fixes the return value to `false` and the error to nil as expected.
bastjan
force-pushed
the
fix-schedule-week-n
branch
from
e3f0246 to
1a7769b
Compare
HappyTetrahedron
approved these changes
Jun 28, 2024
Yes as it is now a separate package with public interface. But:
I think it will be simpler long term to just copy paste. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We incorrectly returned an error in the helper function
CheckIsoWeekif ISO weekNdid not match current week. This PR fixes the return value tofalseand the error to nil as expected.Checklist
bug,enhancement,documentation,change,breaking,dependencyas they show up in the changelog