Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow marking UpgradeJobHooks disruptive #45

Merged
merged 1 commit into from
Sep 13, 2023
Merged

Allow marking UpgradeJobHooks disruptive #45

merged 1 commit into from
Sep 13, 2023

Conversation

bastjan
Copy link
Contributor

@bastjan bastjan commented Sep 12, 2023 •
edited
Loading

Summary

Fixes #37

  • Adds a new field to the UpgradeJobHook CRD .spec.disruptive
  • Adds a new metric label to reflect if a job has disruptive hooks matches_disruptive_hooks.
    • Label changes are breaking changes.
  • Adds an environment variable to all hook jobs/their containers if there is a disruptive hook job matching the current upgrade job META_matchesDisruptiveHooks.

Checklist

  • Categorize the PR by setting a good title and adding one of the labels:
    bug, enhancement, documentation, change, breaking, dependency
    as they show up in the changelog
  • Update tests.
  • Link this PR to related issues.

@bastjan bastjan force-pushed the allow-marking-hooks-disruptive branch 2 times, most recently from 909a3d5 to d59632f Compare September 12, 2023 15:41
@bastjan bastjan force-pushed the allow-marking-hooks-disruptive branch from d59632f to 93dd67c Compare September 12, 2023 15:45
@bastjan bastjan marked this pull request as ready for review September 12, 2023 15:46
@bastjan bastjan requested a review from a team as a code owner September 12, 2023 15:46
@bastjan bastjan merged commit 7e7d5bc into master Sep 13, 2023
@bastjan bastjan deleted the allow-marking-hooks-disruptive branch September 13, 2023 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simu simu simu approved these changes

Assignees
No one assigned
Labels
breaking
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow distinction between possibly disruptive and non-disruptive UpgradeJobHooks
2 participants
@bastjan @simu