Simplify node_draining metric by switching to just in time collection.
#153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By collecting just in time we don't need to worry about stale metrics due to node deletions. Since the client reads are cached by default this does not add load to the API server.
bastjan
changed the title
node_draining metric by switch to just in time collection.node_draining metric by switching to just in time collection.
HappyTetrahedron
approved these changes
Feb 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By collecting just in time we don't need to worry about stale metrics due to node deletions. Since the client reads are cached by default this does not add load to the API server.
Review might be easier by just looking at the updated file instead of the diff.
Checklist
bug,enhancement,documentation,change,breaking,dependencyas they show up in the changelog