Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NodeDrainer: Record pod deletion events on draining node #152

Merged
merged 1 commit into from
Feb 18, 2025
Merged

NodeDrainer: Record pod deletion events on draining node #152

merged 1 commit into from
Feb 18, 2025

Conversation

bastjan
Copy link
Contributor

@bastjan bastjan commented Feb 18, 2025

Checklist

  • Categorize the PR by setting a good title and adding one of the labels:
    bug, enhancement, documentation, change, breaking, dependency
    as they show up in the changelog
  • Update tests.

@bastjan bastjan added the enhancement New feature or request label Feb 18, 2025
@bastjan bastjan requested a review from a team as a code owner February 18, 2025 12:27
simu
simu approved these changes Feb 18, 2025
View reviewed changes
Copy link
Member

@simu simu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a good idea to get some visibility into the force drains without having to comb through the controller logs.

@bastjan bastjan merged commit b05850d into master Feb 18, 2025
3 checks passed
@bastjan bastjan deleted the record-pod-deletion-event-drain branch February 18, 2025 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simu simu simu approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bastjan @simu