Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increase default resource request/limit for API server #32

Merged
merged 1 commit into from
Feb 4, 2022
Merged

Increase default resource request/limit for API server #32

merged 1 commit into from
Feb 4, 2022

Conversation

glrf
Copy link
Contributor

@glrf glrf commented Feb 4, 2022 •
edited
Loading

  • Increase memory limit and request. While memory usage was not higher during testing, increasing this can lead to better performance on a larger cluster, because caching
  • Allow CPU to spike for lower latency
  • Switch to pull policy always. This lead to some issues when using tag latest

Checklist

  • PR contains a single logical change (to build a better changelog).
  • Categorize the PR by setting a good title and adding one of the labels:
    bug, enhancement, documentation, change, breaking, dependency
    as they show up in the changelog.

@glrf glrf added the bug Something isn't working label Feb 4, 2022
@glrf glrf self-assigned this Feb 4, 2022
@glrf glrf requested a review from bastjan February 4, 2022 09:21
@glrf
Copy link
Contributor Author

glrf commented Feb 4, 2022

@gerbermichi Does this line up with the increased limits you set?

@gerbermichi
Copy link

@glrf Yes 🚀

bastjan
bastjan approved these changes Feb 4, 2022
View reviewed changes
Copy link
Contributor

@bastjan bastjan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

imagePullPolicy: could be removed too. Default is Always for :latest.

@glrf
Increase default resource request/limit for API server
ede4865 
* Increase memory limit and request. While memory usage was not higher
  during testing, increasing this can lead to better performance on a
  busy cluster, because caching
* Allow CPU to spike for lower latency
* Remove pull policy. This lead to some issues when using tag
  latest
@glrf glrf force-pushed the fix/increase-default-resources branch from 53e5681 to ede4865 Compare February 4, 2022 09:51
@glrf glrf merged commit 1728a69 into master Feb 4, 2022
@glrf glrf deleted the fix/increase-default-resources branch February 4, 2022 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bastjan bastjan bastjan approved these changes

Assignees

@glrf glrf

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@glrf @gerbermichi @bastjan