Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate OAuth2 OIDC Authentication #32

Merged
merged 12 commits into from
Dec 10, 2021
Merged

Integrate OAuth2 OIDC Authentication #32

merged 12 commits into from
Dec 10, 2021

Conversation

gerbermichi
Copy link
Contributor

Summary

Use the angular-oauth2-oidc (https://github.com/manfredsteyer/angular-oauth2-oidc) library to integrate OAuth2 OIDC authentication into angular. The issuer URL and the client ID can be set in the config.json file. This configuration file must be replaced for the individual deployments.

Closes #5
Closes #13
Closes #11

Copy link
Contributor

@mircowidmer mircowidmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor issues

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
docker/realm.json Show resolved Hide resolved
src/app/app.component.ts Show resolved Hide resolved
src/app/app-config.service.ts Outdated Show resolved Hide resolved
src/app/navbar-item/navbar-item.component.html Outdated Show resolved Hide resolved
gerbermichi and others added 5 commits December 9, 2021 15:49
Co-authored-by: Mirco Widmer <mirco.widmer@gmail.com>
Co-authored-by: Mirco Widmer <mirco.widmer@gmail.com>
@gerbermichi gerbermichi marked this pull request as ready for review December 9, 2021 14:55
Copy link
Contributor

@ccremer ccremer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall, though I didn't review the TS files.

docker-compose.yml Outdated Show resolved Hide resolved
src/config.json Show resolved Hide resolved
Co-authored-by: Chris <github.account@chrigel.net>
@gerbermichi gerbermichi merged commit 5c5a5b0 into master Dec 10, 2021
@gerbermichi gerbermichi deleted the oidc-login branch December 10, 2021 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants