-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integrate OAuth2 OIDC Authentication #32
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gerbermichi
force-pushed
the
oidc-login
branch
from
December 8, 2021 09:48
7e68007
to
ffb1dd5
Compare
gerbermichi
force-pushed
the
oidc-login
branch
from
December 8, 2021 09:51
ffb1dd5
to
e1fd4d9
Compare
gerbermichi
force-pushed
the
oidc-login
branch
from
December 8, 2021 09:54
e1fd4d9
to
7ab08de
Compare
mircowidmer
approved these changes
Dec 9, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minor issues
Co-authored-by: Mirco Widmer <mirco.widmer@gmail.com>
Co-authored-by: Mirco Widmer <mirco.widmer@gmail.com>
ccremer
approved these changes
Dec 9, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM overall, though I didn't review the TS files.
Co-authored-by: Chris <github.account@chrigel.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Use the angular-oauth2-oidc (https://github.com/manfredsteyer/angular-oauth2-oidc) library to integrate OAuth2 OIDC authentication into angular. The issuer URL and the client ID can be set in the
config.json
file. This configuration file must be replaced for the individual deployments.Closes #5
Closes #13
Closes #11