Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stardog] Remove PVC label, upgrade #59

Merged
merged 2 commits into from
Jun 14, 2019
Merged

Conversation

srueg
Copy link
Contributor

@srueg srueg commented Jun 14, 2019

What this PR does / why we need it:

Remove labels from PVC.
Upgrade Stardog.

Checklist

  • DCO signed
  • Chart Version bumped
  • Title of the PR contains starts with chart name e.g. [chart]

Simon Rüegg added 2 commits June 14, 2019 14:23
Otherwise updates are not possible. See this issue [1] for more details.

[1] helm/charts#7803

Signed-off-by: Simon Rüegg <simon.ruegg@vshn.ch>
See [1] for release notes.

[1] https://www.stardog.com/docs/release-notes/#_6_2_2_release_2019_06_05

Signed-off-by: Simon Rüegg <simon.ruegg@vshn.ch>
@srueg srueg requested a review from anothertobi June 14, 2019 12:27
Copy link
Contributor

@anothertobi anothertobi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are we removing the label from the PVC?

@srueg
Copy link
Contributor Author

srueg commented Jun 14, 2019

Why are we removing the label from the PVC?

Because volumeClaimTemplates of StatefulSets are immutable and this label is changing on every new chart release. See helm/charts#7803 for reference.

@anothertobi
Copy link
Contributor

Thanks for the clarification 👍
Change LGTM

@anothertobi anothertobi merged commit 50e6856 into master Jun 14, 2019
@anothertobi anothertobi deleted the stardog/remove-pvc-label branch June 14, 2019 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants