Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(signalilo): ingress support #456

Merged
merged 8 commits into from
Feb 9, 2023
Merged

Conversation

inisitijitty
Copy link
Contributor

@inisitijitty inisitijitty commented Feb 8, 2023

What this PR does / why we need it:

  • fixes signalilo ingress support
    • {{ include "signalilo.fullname" }} on line 5 was missing the scope
    • {{ include "signalilo.fullname" }} on line 24 was missing scope and would not work (because the scope was .Values.ingress.hosts)
    • - host: {{ .host | quote }} on line 18 was an incorrect slice since the structure didn't contain the host element
  • added a few more things like ingress.className, previous apiVersion, previous backend syntax, ...

Checklist

  • Chart Version bumped
  • I have run make docs
  • Variables are documented in the values.yaml using the format required by Helm-Docs.
  • PR contains the label that identifies the chart, e.g. chart/<chart-name>
  • PR contains the label that identifies the type of change, which is one of
    [ bug, enhancement, documentation, change, breaking, dependency ]

@inisitijitty inisitijitty marked this pull request as ready for review February 8, 2023 21:44
@inisitijitty inisitijitty requested a review from simu as a code owner February 8, 2023 21:44
Copy link
Contributor

@hairmare hairmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

drive by review that says; much better, very chart, such deployment (aka lgtm)

coming from a highly opinionated pov tbh

@simu simu added chart/signalilo bug Something isn't working labels Feb 9, 2023
@simu simu merged commit 98c9e98 into appuio:master Feb 9, 2023
@simu
Copy link
Member

simu commented Feb 9, 2023

Thanks for the contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working chart/signalilo
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants