Add vCPU query for APPUiO Managed OpenShift #127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anothertobi
commented
Mar 2, 2023
anothertobi
force-pushed
the
feature/appuio-managed-ocp-vcpu
branch
from
5f90a70 to
95538fa
Compare
bastjan
reviewed
Mar 3, 2023
There was a problem hiding this comment.
Two things:
- I'd prefer one query that spits out different products, based on the labels. This would remove a ton of duplication not only here but also in the cronjob definitions.
- There should be at least a happy path test as in https://github.com/appuio/appuio-cloud-reporting/blob/master/pkg/db/seeds/promtest/appuio_cloud_persistent_storage.jsonnet.
bastjan
force-pushed
the
feature/appuio-managed-ocp-vcpu
branch
from
3f06bc1 to
62c70b8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Checklist
bug,enhancement,documentation,change,breaking,dependencyas they show up in the changelog