Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to gotest.tools/v3 #4382

Merged
merged 1 commit into from
Sep 4, 2019
Merged

Update to gotest.tools/v3 #4382

merged 1 commit into from
Sep 4, 2019

Conversation

mem
Copy link
Contributor

@mem mem commented Sep 4, 2019

Signed-off-by: Marcelo E. Magallon marcelo@sylabs.io

Description of the Pull Request (PR):

Write your description of the PR here. Be sure to include as much background,
and details necessary for the reviewers to understand exactly what this is
fixing or enhancing.

This fixes or addresses the following GitHub issues:

Before submitting a PR, make sure you have done the following:

Attn: @singularity-maintainers

Signed-off-by: Marcelo E. Magallon <marcelo@sylabs.io>
@tri-adam tri-adam self-requested a review September 4, 2019 20:43
Copy link
Contributor

@tri-adam tri-adam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Tested with:

+replace github.com/sylabs/singularity => github.com/mem/singularity v0.0.0-20190904202734-c11c37dab640

and can confirm I'm no longer seeing #4381. Thank you!

@mem mem merged commit b6230c6 into apptainer:master Sep 4, 2019
@mem mem deleted the update_gotest.tools branch September 4, 2019 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issue Importing from Projects Using Go 1.13
2 participants