Skip to content
This repository has been archived by the owner on Aug 6, 2024. It is now read-only.

chore: Adding icons in AppIcon component and Icon provider #667

Merged
merged 2 commits into from
Oct 30, 2023

Conversation

ankitakinger
Copy link
Contributor

@ankitakinger ankitakinger commented Oct 27, 2023

Description

Adding icons in AppIcon component and Icon provider to support package and module icons.

Fixes #26051

Depends on #2764

Type of change

  • Chore (housekeeping or task changes that don't impact user perception)

How Has This Been Tested?

  • Manual on storybook
  • Manual on main repo

Checklist:

Dev activity

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

QA activity:

  • Test plan has been approved by relevant developers
  • Test plan has been peer reviewed by QA
  • Cypress test cases have been added and approved by either SDET or manual QA
  • Organized project review call with relevant stakeholders after Round 1/2 of QA
  • Added Test Plan Approved label after reveiwing all Cypress test

@changeset-bot
Copy link

changeset-bot bot commented Oct 27, 2023

🦋 Changeset detected

Latest commit: a684a4e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@appsmithorg/design-system-old Patch
@appsmithorg/design-system Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Oct 27, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
design-system ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 27, 2023 2:28pm

@ankitakinger
Copy link
Contributor Author

/generate-alpha

@ankitakinger ankitakinger merged commit 40b67d9 into release Oct 30, 2023
@ankitakinger ankitakinger deleted the chore/add-icons branch October 30, 2023 10:40
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Task] Module creation sagas + API wiring
2 participants