Skip to content
This repository has been archived by the owner on Aug 6, 2024. It is now read-only.

fix: Updating tag input value to original value, when the form is reset #642

Merged
merged 4 commits into from
Oct 2, 2023

Conversation

ankitakinger
Copy link
Contributor

@ankitakinger ankitakinger commented Sep 27, 2023

Description

Updating tag input value to original value, when the form is reset

Fixes #27671

Depends on #27681 #2485

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

  • Manual on storybook
  • Manual on main repo

Checklist:

Dev activity

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

QA activity:

  • Test plan has been approved by relevant developers
  • Test plan has been peer reviewed by QA
  • Cypress test cases have been added and approved by either SDET or manual QA
  • Organized project review call with relevant stakeholders after Round 1/2 of QA
  • Added Test Plan Approved label after reveiwing all Cypress test

@changeset-bot
Copy link

changeset-bot bot commented Sep 27, 2023

🦋 Changeset detected

Latest commit: 3cd4fd8

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@appsmithorg/design-system-old Patch
@appsmithorg/design-system Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Sep 27, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
design-system ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 28, 2023 5:53am

@ankitakinger
Copy link
Contributor Author

/generate-alpha

@ankitakinger
Copy link
Contributor Author

/generate-alpha

1 similar comment
@albinAppsmith
Copy link
Contributor

/generate-alpha

@albinAppsmith
Copy link
Contributor

/generate-alpha

@RakshaKShetty
Copy link

@ankitakinger , @albinAppsmith the value gets reset to the removed value before its saved and restarted

@ankitakinger ankitakinger merged commit 8b29382 into release Oct 2, 2023
@ankitakinger ankitakinger deleted the fix/tag-input-values-update branch October 2, 2023 09:36
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working Needs Triaging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Admin emails list is not getting reset when we clear changes on Admin settings page
3 participants