fix: suppress error toast for update notifications

[alex-golovanov]

Description

Prevents error toasts for errors designed to show update notification toasts.

Automation

/ok-to-test tags="@tag.Sanity"

🔍 Cypress test results

Tip

🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/12811573044
Commit: 444b428
Cypress dashboard.
Tags: @tag.Sanity
Spec:

---

Thu, 16 Jan 2025 15:41:29 UTC

Communication

Should the DevRel and Marketing teams inform users about this change?

• Yes
• No

Summary by CodeRabbit

• Bug Fixes
  • Updated error handling mechanism for bad request errors
  • Refined version mismatch error processing

[coderabbitai]

Walkthrough

The pull request modifies the handleBadRequestError function in the response interceptor, significantly altering its error handling approach. The changes remove detailed error message capturing and promise rejection mechanics, instead simplifying the function to perform a basic version mismatch check and return null for other scenarios. This represents a fundamental shift in how bad request errors are processed within the application's API interceptor logic.

Changes

File	Change Summary
app/client/src/api/interceptors/.../handleBadRequestError.ts	- Removed error message assignment - Eliminated detailed error promise rejection - Simplified error handling to version mismatch check - Function now returns null instead of rejected promise

Suggested Labels

bug, ok-to-test

Suggested Reviewers

• hetunandu
• ApekshaBhosale
• sagar-qa007

Poem

🚨 Error handler's dance, a code ballet so rare
Where messages vanish into thin air
Null returns with a mischievous grin
Version mismatches make reviewers spin
A refactor's tale, both curious and bold! 🔍

---

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 56f968f and 444b428.

📒 Files selected for processing (1)

• app/client/src/api/interceptors/response/failureHandlers/handleBadRequestError.ts (0 hunks)

💤 Files with no reviewable changes (1)

• app/client/src/api/interceptors/response/failureHandlers/handleBadRequestError.ts

⏰ Context from checks skipped due to timeout of 90000ms (6)

• GitHub Check: copy-labels-from-issue
• GitHub Check: client-check-cyclic-deps / check-cyclic-dependencies
• GitHub Check: client-unit-tests / client-unit-tests
• GitHub Check: client-build / client-build
• GitHub Check: client-lint / client-lint
• GitHub Check: client-prettier / prettier-check

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.