Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: return true if command fails #38662

Merged
merged 2 commits into from
Jan 15, 2025
Merged

Conversation

sagar-qa007
Copy link
Contributor

@sagar-qa007 sagar-qa007 commented Jan 15, 2025

Description

Tip

Add a TL;DR when the description is longer than 500 words or extremely technical (helps the content, marketing, and DevRel team).

Please also include relevant motivation and context. List any dependencies that are required for this change. Add links to Notion, Figma or any other documents that might be relevant to the PR.

Fixes #Issue Number
or
Fixes Issue URL

Warning

If no issue exists, please create an issue first, and check with the maintainers if the issue is valid.

Automation

/ok-to-test tags="@tag.Settings"

🔍 Cypress test results

Warning

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/12783163366
Commit: 0a2d970
Cypress dashboard.
Tags: @tag.Settings
Spec:
It seems like no tests ran 😔. We are not able to recognize it, please check workflow here.


Wed, 15 Jan 2025 07:03:35 UTC

Communication

Should the DevRel and Marketing teams inform users about this change?

  • Yes
  • No

Summary by CodeRabbit

  • Chores
    • Improved error handling in the GitHub Actions workflow for saving Docker images, allowing the process to continue even if image removal encounters an error.

@sagar-qa007 sagar-qa007 requested a review from sharat87 as a code owner January 15, 2025 06:49
@sagar-qa007 sagar-qa007 added the ok-to-test Required label for CI label Jan 15, 2025
Copy link
Contributor

coderabbitai bot commented Jan 15, 2025

Warning

Rate limit exceeded

@sagar-qa007 has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 4 minutes and 59 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📥 Commits

Reviewing files that changed from the base of the PR and between 32c39fb and 0a2d970.

📒 Files selected for processing (1)
  • .github/workflows/build-docker-image.yml (1 hunks)

Walkthrough

The pull request modifies the error handling in the "Save Docker image to tar file" step of the GitHub Actions workflow. The command that removes unused Docker images has been updated to ensure that the workflow continues executing even if the docker rmi command encounters an error. This is achieved by appending || true to the command, allowing for smoother error management in the workflow.

Changes

File Change Summary
.github/workflows/build-docker-image.yml Modified error handling in the Docker image removal command by adding `

Possibly related PRs

  • ci: Do not fail on image remove #38660: Modifies the same command in the .github/workflows/build-docker-image.yml file, specifically enhancing error handling for the Docker image removal process, which is directly related to the changes made in the main PR.
  • ci: return true if command fails #38662: Updates a description in the same workflow file, indicating ongoing modifications in the same context, but does not directly relate to the error handling changes.

Suggested reviewers

  • sharat87
  • yatinappsmith

Poem

🐳 In the workflow's dance, a change so fine,
Docker's image removal, now more divine.
Errors brushed aside, with a flick of true,
The process flows on, like morning dew.
A gentle nudge to keep things bright,
In the CI world, everything feels right! 🚀


🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@sagar-qa007 sagar-qa007 changed the title DNM: sample run ci: return true if command fails Jan 15, 2025
@sagar-qa007 sagar-qa007 added ok-to-test Required label for CI and removed ok-to-test Required label for CI labels Jan 15, 2025
@github-actions github-actions bot added skip-changelog Adding this label to a PR prevents it from being listed in the changelog CI labels Jan 15, 2025
@sagar-qa007 sagar-qa007 removed the ok-to-test Required label for CI label Jan 15, 2025
@sagar-qa007 sagar-qa007 added the ok-to-test Required label for CI label Jan 15, 2025
@yatinappsmith yatinappsmith merged commit 0106489 into release Jan 15, 2025
24 of 35 checks passed
@yatinappsmith yatinappsmith deleted the ci/testingdockerchanges branch January 15, 2025 07:01
@coderabbitai coderabbitai bot mentioned this pull request Jan 15, 2025
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI ok-to-test Required label for CI skip-changelog Adding this label to a PR prevents it from being listed in the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants