Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: disabledWhenInvalid in ButtonGroupWidget #38656

Open
wants to merge 6 commits into
base: release
Choose a base branch
from
Open

feat: disabledWhenInvalid in ButtonGroupWidget #38656

wants to merge 6 commits into from
+142 −6

Conversation

devin-ai-integration[bot]
Copy link
Contributor

@devin-ai-integration devin-ai-integration bot commented Jan 15, 2025 •
edited by github-actions bot
Loading

Resolves #38653

Link to Devin run: https://app.devin.ai/sessions/d82b2fcf70344f21a0ff666b955a8da2

Automation

/ok-to-test tags="@tag.Widget"

🔍 Cypress test results

Tip

🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/12783995167
Commit: e71e6e0
Cypress dashboard.
Tags: @tag.Widget
Spec:

Wed, 15 Jan 2025 09:29:21 UTC

@devin-ai-integration @rahulbarwal
feat: Add disabledWhenInvalid property to each button in ButtonGroupW…
e219372 
…idget

Co-Authored-By: rahul.barwal@appsmith.com <rahul.barwal@appsmith.com>
@devin-ai-integration Devin.ai Integration
Copy link
Contributor Author

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR. Add "(aside)" to your comment to have me ignore it.
  • Look at CI failures and help fix them

⚙️ Control Options:

  • Disable automatic comment and CI monitoring

@coderabbitai coderabbitai
Copy link
Contributor

coderabbitai bot commented Jan 15, 2025

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions github-actions bot added Button Group widget Issue and enhancements related to the button group widget Enhancement New feature or request Widgets & Accelerators Pod Issues related to widgets & Accelerators Widgets Product This label groups issues related to widgets labels Jan 15, 2025
devin-ai-integration bot and others added 2 commits January 15, 2025 06:31
@devin-ai-integration @rahulbarwal
style: Fix prettier formatting issues
ae20515 
Co-Authored-By: rahul.barwal@appsmith.com <rahul.barwal@appsmith.com>
@devin-ai-integration @rahulbarwal
fix: Add missing required props in ButtonGroupWidget test
60617ed 
Co-Authored-By: rahul.barwal@appsmith.com <rahul.barwal@appsmith.com>
@devin-ai-integration Devin.ai Integration
Copy link
Contributor Author

Devin is currently unreachable - the session may have died.

@rahulbarwal
Merge branch 'release' of https://github.com/appsmithorg/appsmith int…
d0c58c1 
…o devin/1736920714-button-group-disabled-prop
@rahulbarwal
Fixes linting issues.
e2b0485 
Co-Authored-By: rahul.barwal@appsmith.com
@rahulbarwal
fix: Update ButtonGroupWidget to correctly handle button disabling ba…
e71e6e0 
…sed on form validity

- Adjusted logic in ButtonGroupComponent to disable buttons when `disabledWhenInvalid` is true and the form is invalid.
- Passed `isFormValid` prop from ButtonGroupWidget to ButtonGroupComponent.
- Updated tests to ensure buttons are enabled/disabled correctly based on the `isFormValid` state.

Co-Authored-By: rahul.barwal@appsmith.com
@rahulbarwal rahulbarwal added the ok-to-test Required label for CI label Jan 15, 2025
@rahulbarwal
Copy link
Contributor

/build-deploy-preview skip-tests=true

@github-actions GitHub Actions
Copy link

Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/12784166072.
Workflow: On demand build Docker image and deploy preview.
skip-tests: true.
env: ``.
PR: 38656.
recreate: .

@github-actions GitHub Actions
Copy link

Deploy-Preview-URL: https://ce-38656.dp.appsmith.com

@rahulbarwal rahulbarwal self-assigned this Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jacquesikot jacquesikot Awaiting requested review from jacquesikot

At least 1 approving review is required to merge this pull request.

Assignees

@rahulbarwal rahulbarwal

Labels
Button Group widget Issue and enhancements related to the button group widget Enhancement New feature or request ok-to-test Required label for CI Widgets & Accelerators Pod Issues related to widgets & Accelerators Widgets Product This label groups issues related to widgets
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature]: Add 'disabled invalid forms' to button group buttons
1 participant
@rahulbarwal