-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Prevent unnecessary meta property resets in List widget #38639
fix: Prevent unnecessary meta property resets in List widget #38639
Conversation
- Add hasRowDataChanged method to track data changes - Improve meta property reset handling - Add tests for hasRowDataChanged functionality - Add debug logging for troubleshooting Fixes #37088 Co-Authored-By: rahul.barwal@appsmith.com <rahul.barwal@appsmith.com>
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
⚙️ Control Options:
|
Important Review skippedBot user detected. To trigger a single review, invoke the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
Co-Authored-By: rahul.barwal@appsmith.com <rahul.barwal@appsmith.com>
This PR has not seen activitiy for a while. It will be closed in 7 days unless further activity is detected. |
Closing due to inactivity. |
Description
This PR addresses issue #37088 where meta properties in List widgets are being unnecessarily reset during widget evaluation. The issue specifically affects Input widgets within List widgets when filtering is applied through a Select widget.
Changes Made
hasRowDataChanged
method to track actual data changesTesting
Documentation
No documentation changes required as this is a bug fix.
Link to Devin run: https://app.devin.ai/sessions/9d9f16b52d204d50a4789cbb50cb7c18
Type of change
How Has This Been Tested?
Checklist:
Automation
/ok-to-test tags="@tag.Widget"
🔍 Cypress test results
Warning
Tests have not run on the HEAD ede04ac yet
Tue, 14 Jan 2025 05:47:52 UTC