fix: external saas redirection when api created and navigated

[AmanAgarwal041]

Description

Earlier on creation of the external saas api, the url doesn't gets redirected to the action page. And on clicking on the created api from the explorer section, the url wasn't getting redirected as well.
This PR fixes both of these

Fixes #38515
or
Fixes Issue URL

Warning

If no issue exists, please create an issue first, and check with the maintainers if the issue is valid.

Automation

/ok-to-test tags="@tag.Datasource"

🔍 Cypress test results

Tip

🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/12651235756
Commit: 35dafe4
Cypress dashboard.
Tags: @tag.Datasource
Spec:

---

Tue, 07 Jan 2025 12:56:07 UTC

Communication

Should the DevRel and Marketing teams inform users about this change?

• Yes
• No

Summary by CodeRabbit

• New Features

  • Added support for External SaaS plugin type across multiple components
  • Enhanced plugin type handling in URL resolution and query creation processes

• Improvements

  • Expanded plugin configuration to recognize and process External SaaS plugins
  • Updated conditional logic to accommodate new plugin type in various system workflows

[coderabbitai]

Walkthrough

The pull request introduces handling for the PluginType.EXTERNAL_SAAS across multiple files in the client application. The changes extend existing logic to recognize and process this new plugin type in various components, including action response tabs, URL resolution, and query creation sagas. The modifications aim to enable proper routing and handling of external SaaS plugin actions.

Changes

File	Change Summary
app/client/src/ce/PluginActionEditor/components/PluginActionResponse/hooks/usePluginActionResponseTabs.tsx	Added PluginType.EXTERNAL_SAAS to conditional logic for displaying datasource schema tabs
app/client/src/pages/Editor/Explorer/Actions/helpers.tsx	Updated resolveActionURL and ACTION_PLUGIN_MAP to include EXTERNAL_SAAS plugin type
app/client/src/sagas/QueryPaneSagas.ts	Added PluginType.EXTERNAL_SAAS to query creation conditional check

Assessment against linked issues

Objective	Addressed	Explanation
Action creation and redirection for External Plugin [#38515]	✅

Possibly related PRs

• chore: [Plugin Action Editor] Query forms in Plugin Action Form #36684: Modifications to PluginActionForm component
• fix: New query button does not show up issue fixed #36766: Updates to resolveActionURL function
• chore: Create query selector #37018: Payload structure updates for datasource creation
• fix: Plugin Action Editor navigation issue with git #37670: Navigation issues related to action IDs
• fix: Updating the logic for datasource selector to fox the client build failure on prod #38107: Datasource component enhancement
• chore: Cherry picking fix for client build failure #38109: Additional Datasource component modifications

Suggested labels

Bug, Enhancement, ok-to-test, Community Reported, Query & JS Pod, Datasources

Suggested reviewers

• ankitakinger

Poem

In the realm of code, a new path unfurls,
External SaaS plugins, their flags now unfurl
Routing and tabs, a dance of delight
Bridging the gaps with algorithmic might
A plugin's journey, now smooth and clear 🚀

---

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between a9a0d71 and 35dafe4.

📒 Files selected for processing (3)

• app/client/src/ce/PluginActionEditor/components/PluginActionResponse/hooks/usePluginActionResponseTabs.tsx (1 hunks)
• app/client/src/pages/Editor/Explorer/Actions/helpers.tsx (2 hunks)
• app/client/src/sagas/QueryPaneSagas.ts (1 hunks)

🔇 Additional comments (4)

app/client/src/pages/Editor/Explorer/Actions/helpers.tsx (2)

65-66: LGTM! Consistent handling of EXTERNAL_SAAS plugin type

The addition of EXTERNAL_SAAS to the queryEditorIdURL resolution path is correct and aligns with the expected behavior.

---

90-90: LGTM! Valid plugin type configuration

EXTERNAL_SAAS is correctly added to the ACTION_PLUGIN_MAP types array, ensuring it's recognized as a valid action type.

app/client/src/ce/PluginActionEditor/components/PluginActionResponse/hooks/usePluginActionResponseTabs.tsx (1)

118-118: LGTM! Consistent tab handling for EXTERNAL_SAAS

EXTERNAL_SAAS is correctly added to the plugin types array, ensuring it gets the same datasource and response tab handling as other similar plugins.

app/client/src/sagas/QueryPaneSagas.ts (1)

401-401: LGTM! Proper saga handling for EXTERNAL_SAAS

EXTERNAL_SAAS is correctly added to the plugin types array in handleQueryCreatedSaga, ensuring proper query creation handling.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[AmanAgarwal041]

/build-deploy-preview skip-tests=true

[github-actions]

Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/12651208056.
Workflow: On demand build Docker image and deploy preview.
skip-tests: true.
env: ``.
PR: 38518.
recreate: .

[github-actions]

Deploy-Preview-URL: https://ce-38518.dp.appsmith.com