-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add grafana faro sdk (CE) #38301
Changes from 16 commits
ee46926
c4ca320
02a8e73
c8c07e5
a5b2046
f6d216e
d466781
789ca05
e9270ed
7a79f71
78f2ead
ab35c43
63d4868
7095223
de9249e
c845ab4
149ab89
4a40d66
265ac2e
33ca23b
5d2881c
3160036
3842f6c
459a9c0
91fe8aa
382098a
6db7362
46a6c29
c9d4264
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -35,7 +35,6 @@ | |
"postcss-url", | ||
"@types/dom-view-transitions", | ||
"@types/jest", | ||
"@sentry/webpack-plugin", | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. "@sentry/react": "^6.2.4" — should this package also be deleted? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We are planning to do this in the next pr. |
||
"compression-webpack-plugin", | ||
"webpack-retry-chunk-load-plugin", | ||
"lint-staged", | ||
|
@@ -47,6 +46,7 @@ | |
"@aws-sdk/lib-storage", | ||
"@octokit/rest", | ||
"@faker-js/faker", | ||
"@grafana/faro-webpack-plugin", | ||
"pg", | ||
"factory.ts" | ||
] | ||
|
This file was deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Codebase verification
Clean up Sentry configuration and implementation
Both Sentry and Grafana Faro instrumentation code are present in the codebase. While Grafana Faro is being implemented (
instrumentation/index.ts
), Sentry is still actively used with a full implementation insentry.ts
and theSENTRY_AUTH_TOKEN
is used in the build workflow. To maintain a clean codebase:SENTRY_AUTH_TOKEN
from the build workflowapp/client/src/utils/Analytics/sentry.ts
and related imports🔗 Analysis chain
Consider cleaning up Sentry configuration
The
SENTRY_AUTH_TOKEN
environment variable is still present while migrating to Grafana Faro.The previous search was limited to YAML files, but Sentry configurations could be present in other file types. Let's broaden our search to verify if there are any remaining Sentry-related configurations or code before making a conclusion.
Let's verify if there are any remaining Sentry configurations and check for the Grafana Faro migration to make a more informed decision.
Let's examine the actual implementation files to understand if Sentry is still actively used or if it's been fully migrated to Grafana Faro.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
Length of output: 35
Script:
Length of output: 71494
Script:
Length of output: 518
Script:
Length of output: 2062