Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update RestApiDatasource_spec.js #38042

Merged
merged 1 commit into from
Dec 9, 2024

Conversation

sagar-qa007
Copy link
Contributor

@sagar-qa007 sagar-qa007 commented Dec 9, 2024

Description

Failure : #37353

Fixes #Issue Number
or
Fixes Issue URL

Warning

If no issue exists, please create an issue first, and check with the maintainers if the issue is valid.

Automation

/ok-to-test tags="@tag.Sanity"

🔍 Cypress test results

Tip

🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/12233151589
Commit: c99b7de
Cypress dashboard.
Tags: @tag.Sanity
Spec:


Mon, 09 Dec 2024 10:37:02 UTC

Communication

Should the DevRel and Marketing teams inform users about this change?

  • Yes
  • No

Summary by CodeRabbit

  • Tests
    • Skipped the test suite for creating a REST datasource due to an associated issue.

Copy link
Contributor

coderabbitai bot commented Dec 9, 2024

Walkthrough

The changes in this pull request involve modifying a test case in the RestApiDatasource_spec.js file by skipping the entire test suite for creating a REST datasource. The describe function is altered to describe.skip, preventing the test from executing due to an associated issue. The internal logic of the test case remains unchanged, but it will not run until the skip condition is addressed.

Changes

File Path Change Summary
app/client/cypress/e2e/Sanity/Datasources/RestApiDatasource_spec.js Modified the test suite to skip execution using describe.skip.

Possibly related PRs

  • test: fix DataSourceScheme #36339: This PR modifies test cases in a related Cypress test file, addressing the skipping of tests due to known bugs, which aligns with the main PR's change of skipping a test suite in a similar context.
  • fix: Reverted changes for skip client cache #37782: This PR reverts changes related to skipping client cache, which may indirectly relate to the testing framework and its handling of skipped tests, similar to the main PR's focus on skipping a test suite.

Suggested labels

Bug, skip-changelog, ok-to-test, Test

Suggested reviewers

  • ApekshaBhosale
  • NandanAnantharamu

Poem

In the realm of code where tests do play,
A suite was skipped, kept bugs at bay.
With describe.skip, it takes a rest,
Awaiting fixes, it knows what's best.
In Cypress land, our tests will thrive,
Until the day they come alive! 🌟


📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between 7184101 and c99b7de.

📒 Files selected for processing (1)
  • app/client/cypress/e2e/Sanity/Datasources/RestApiDatasource_spec.js (1 hunks)
✅ Files skipped from review due to trivial changes (1)
  • app/client/cypress/e2e/Sanity/Datasources/RestApiDatasource_spec.js

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions github-actions bot added the skip-changelog Adding this label to a PR prevents it from being listed in the changelog label Dec 9, 2024
@sagar-qa007 sagar-qa007 added the ok-to-test Required label for CI label Dec 9, 2024
@sagar-qa007 sagar-qa007 merged commit 3345a27 into release Dec 9, 2024
46 checks passed
@sagar-qa007 sagar-qa007 deleted the chore/skipbugrelatedcase branch December 9, 2024 10:48
@coderabbitai coderabbitai bot mentioned this pull request Dec 9, 2024
2 tasks
github-actions bot pushed a commit to Zeral-Zhang/appsmith that referenced this pull request Dec 12, 2024
## Description
Failure : appsmithorg#37353

Fixes #`Issue Number`  
_or_  
Fixes `Issue URL`
> [!WARNING]  
> _If no issue exists, please create an issue first, and check with the
maintainers if the issue is valid._

## Automation

/ok-to-test tags="@tag.Sanity"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/12233151589>
> Commit: c99b7de
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=12233151589&attempt=1"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.Sanity`
> Spec:
> <hr>Mon, 09 Dec 2024 10:37:02 UTC
<!-- end of auto-generated comment: Cypress test results  -->


## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [x] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **Tests**
- Skipped the test suite for creating a REST datasource due to an
associated issue.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ok-to-test Required label for CI skip-changelog Adding this label to a PR prevents it from being listed in the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants