Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: edit and launch button fail on keeping mouse over while reload #36954

Conversation

ALOK9442
Copy link
Contributor

@ALOK9442 ALOK9442 commented Oct 17, 2024

Description

Fixes edit and launch buttons fail to appear if mouse pointer is hovering over the Application box while loading webpage
Tested it thoroughly.

appsmithbutton.mp4

Fixes #36804

Automation

/ok-to-test tags=""

🔍 Cypress test results

Caution

If you modify the content in this section, you are likely to disrupt the CI result for your PR.

Communication

Should the DevRel and Marketing teams inform users about this change?

  • Yes
  • No

Summary by CodeRabbit

  • Bug Fixes

    • Updated mouse event handling in the Card component for improved overlay display behavior.
  • Refactor

    • Adjusted event triggering from onMouseEnter to onMouseOver without altering overall functionality.

Copy link
Contributor

coderabbitai bot commented Oct 17, 2024

Walkthrough

The changes in this pull request involve modifying the mouse event handler in the Card component from onMouseEnter to onMouseOver. This adjustment impacts how the overlay is displayed during mouse interactions, while the logic for controlling the overlay visibility remains unchanged. The overall functionality and structure of the Card component are preserved.

Changes

File Change Summary
app/client/src/components/common/Card.tsx Changed mouse event handler from onMouseEnter to onMouseOver in NameWrapper component.

Assessment against linked issues

Objective Addressed Explanation
Ensure Edit and Launch buttons appear when mouse is hovering over the Application box (36804)

Suggested labels

Bug, Low, Production, UX Improvement, IDE Product, IDE Pod, ok-to-test

Suggested reviewers

  • ankitakinger

🎉 In the realm of code, a change so bright,
The Card now dances with mouse in flight.
From Enter to Over, a tweak so grand,
Buttons now shine, just as we planned!
With overlays ready, they’re set to delight,
A small fix, but oh, what a sight! 🌟


📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL

📥 Commits

Files that changed from the base of the PR and between 6b0eae8 and bc39cfb.

📒 Files selected for processing (1)
  • app/client/src/components/common/Card.tsx (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • app/client/src/components/common/Card.tsx

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL

📥 Commits

Files that changed from the base of the PR and between ebec99c and 6b0eae8.

📒 Files selected for processing (1)
  • app/client/src/components/common/Card.tsx (1 hunks)
🧰 Additional context used

app/client/src/components/common/Card.tsx Outdated Show resolved Hide resolved
@ankitakinger
Copy link
Contributor

@ALOK9442 Could you rearrange the props onMouseOver and onMouseLeave alphabetically? It causing lint failure.

@ALOK9442
Copy link
Contributor Author

ALOK9442 commented Oct 17, 2024

hey @ankitakinger , could you check this error as I searched this error and it is saying to rename the file .eslintrc.js file, to eslint.config.js
which I got after commiting the changes
ps: if I rename the file to eslint.config.js it is not giving me error so can you check this
Screenshot 2024-10-17 215805

@ankitakinger
Copy link
Contributor

@ALOK9442 can you try by going in to the client folder first on your terminal and then do the commit?

cd app/client
git commit -m "fix: linting error reorder props alphabetically"

@ALOK9442
Copy link
Contributor Author

@ankitakinger , I tried and still getting the same error and also a new error of gitleaks
image

@ankitakinger
Copy link
Contributor

@ALOK9442 Seems like you have a higher version of eslint installed. Can you commit with the --no-verify flag here?

@ALOK9442
Copy link
Contributor Author

--no-verify

I have commit the changes, please check

@ALOK9442
Copy link
Contributor Author

@ALOK9442 you haven't pushed the changes it seems

Sorry, it got delayed because of internet issue, it's done now

@ankitakinger ankitakinger self-requested a review October 17, 2024 18:12
@ankitakinger ankitakinger merged commit e5e6989 into appsmithorg:release Oct 17, 2024
100 of 101 checks passed
@coderabbitai coderabbitai bot mentioned this pull request Oct 18, 2024
2 tasks
@ankitakinger
Copy link
Contributor

@ALOK9442 Thank you for your contribution.

@ALOK9442
Copy link
Contributor Author

@ALOK9442 Thank you for your contribution.

@ankitakinger I'm glad I could help

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants