Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: unskip redis test #36863

Merged
merged 2 commits into from
Oct 16, 2024
Merged

chore: unskip redis test #36863

merged 2 commits into from
Oct 16, 2024

Conversation

sneha122
Copy link
Contributor

@sneha122 sneha122 commented Oct 14, 2024

Description

This PR enables back the RedisPluginTest Junit test case. It was disabled earlier as it was failing in build promotion. I have ran the test case multiple times on local and it did not fail at all, hence enabling it back. Will run it couple of times in CI too.

Fixes #36774
or
Fixes Issue URL

Warning

If no issue exists, please create an issue first, and check with the maintainers if the issue is valid.

Automation

/ok-to-test tags="@tag.Sanity"

🔍 Cypress test results

Tip

🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/11348382724
Commit: 91dce61
Cypress dashboard.
Tags: @tag.Sanity
Spec:


Tue, 15 Oct 2024 15:38:37 UTC

Communication

Should the DevRel and Marketing teams inform users about this change?

  • Yes
  • No

Summary by CodeRabbit

  • Bug Fixes

    • Enabled the RedisPluginTest class for execution, allowing all test methods to run and validate the Redis plugin's behavior.
  • Tests

    • No changes to the logic or structure of existing tests; focus remains on validating datasource configurations and command execution.

Copy link
Contributor

coderabbitai bot commented Oct 14, 2024

Walkthrough

The changes involve modifications to the RedisPluginTest class within the redisPlugin module. The primary alteration is the removal of the @Disabled annotation, which enables the execution of all test methods in the class. The tests remain unchanged in their logic and structure, continuing to validate the Redis plugin's functionality, including datasource creation and command execution.

Changes

File Path Change Summary
app/server/appsmith-plugins/redisPlugin/src/test/java/com/external/plugins/RedisPluginTest.java Removed @Disabled annotation to enable test execution.

Possibly related PRs

Suggested labels

ok-to-test, Test, skip-changelog

Suggested reviewers

  • nidhi-nair
  • abhvsn

🎉 In the land of code, where tests reside,
The RedisPluginTest now takes a stride.
With @Disabled gone, it’s time to run,
Validating commands, oh what fun!
So let’s cheer for tests, both bold and bright,
Ensuring our plugin works just right! 🎊


📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL

📥 Commits

Files that changed from the base of the PR and between 97f2560 and 91dce61.

📒 Files selected for processing (1)
  • app/server/appsmith-plugins/redisPlugin/src/test/java/com/external/plugins/RedisPluginTest.java (0 hunks)
💤 Files with no reviewable changes (1)
  • app/server/appsmith-plugins/redisPlugin/src/test/java/com/external/plugins/RedisPluginTest.java

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions github-actions bot added the skip-changelog Adding this label to a PR prevents it from being listed in the changelog label Oct 14, 2024
@sneha122 sneha122 added ok-to-test Required label for CI and removed skip-changelog Adding this label to a PR prevents it from being listed in the changelog labels Oct 14, 2024
@sneha122 sneha122 requested review from abhvsn and removed request for abhvsn October 14, 2024 10:53
@github-actions github-actions bot added skip-changelog Adding this label to a PR prevents it from being listed in the changelog Backend This marks the issue or pull request to reference server code Integrations Product Issues related to a specific integration MsSQL Issues related to MsSQL plugin Query & JS Pod Issues related to the query & JS Pod Redis Issues related to Redis Task A simple Todo labels Oct 14, 2024
Copy link

Failed server tests

  • com.appsmith.server.services.ce.ActionServiceCE_Test#testActionWithGraphQLDatasourceMoustacheBinding

@sagar-qa007 sagar-qa007 added ok-to-test Required label for CI and removed ok-to-test Required label for CI labels Oct 14, 2024
@sneha122 sneha122 added ok-to-test Required label for CI and removed ok-to-test Required label for CI labels Oct 15, 2024
@sneha122 sneha122 merged commit 00c16e8 into release Oct 16, 2024
108 of 113 checks passed
@sneha122 sneha122 deleted the chore/unskip-redis-test branch October 16, 2024 06:39
github-actions bot pushed a commit to Zeral-Zhang/appsmith that referenced this pull request Oct 17, 2024
## Description
This PR enables back the RedisPluginTest Junit test case. It was
disabled earlier as it was failing in build promotion. I have ran the
test case multiple times on local and it did not fail at all, hence
enabling it back. Will run it couple of times in CI too.


Fixes appsmithorg#36774  
_or_  
Fixes `Issue URL`
> [!WARNING]  
> _If no issue exists, please create an issue first, and check with the
maintainers if the issue is valid._

## Automation

/ok-to-test tags="@tag.Sanity"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/11348382724>
> Commit: 91dce61
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=11348382724&attempt=2"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.Sanity`
> Spec:
> <hr>Tue, 15 Oct 2024 15:38:37 UTC
<!-- end of auto-generated comment: Cypress test results  -->


## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [x] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **Bug Fixes**
- Enabled the `RedisPluginTest` class for execution, allowing all test
methods to run and validate the Redis plugin's behavior.

- **Tests**
- No changes to the logic or structure of existing tests; focus remains
on validating datasource configurations and command execution.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->

Co-authored-by: “sneha122” <“sneha@appsmith.com”>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Backend This marks the issue or pull request to reference server code Integrations Product Issues related to a specific integration MsSQL Issues related to MsSQL plugin ok-to-test Required label for CI Query & JS Pod Issues related to the query & JS Pod Redis Issues related to Redis skip-changelog Adding this label to a PR prevents it from being listed in the changelog Task A simple Todo
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Task]: Fix flaky server tests of MSSQL and Redis
3 participants