chore: Add logs for default DB url for CI test workflows #36506
Conversation
WalkthroughThe changes introduced in this pull request enhance the GitHub Actions workflows by adding new steps that check the database URL and determine the database type being used. A conditional step named "Check DB URL" has been added to the CI workflow, while a new job called "Default database URL" has been introduced in the server build workflow. These modifications allow for better handling of database configurations during the CI process. Changes
Possibly related PRs
Suggested reviewers
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
github-actions
bot
added
the
skip-changelog
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Files selected for processing (2)
- .github/workflows/ci-test-custom-script.yml (1 hunks)
- .github/workflows/server-build.yml (1 hunks)
Additional comments not posted (2)
.github/workflows/server-build.yml (2)
75-77: Class, let's examine this new step in our workflow.Good morning, students! Today, we're going to learn about a new addition to our GitHub Actions workflow. Can anyone tell me what this step does?
- name: Default database URL run: echo "Is this a PG build? ${{ inputs.is-pg-build }}"That's right! This step is like raising your hand in class to let everyone know what type of database we're using. It's very important because it helps us keep track of our build environment.
Now, can anyone tell me why this might be useful? Think about how it could help us troubleshoot issues or understand our test results better.
This addition is a good step towards improving our logging and visibility into the build process. Well done!
Class, for your homework, I want you to think about other pieces of information we might want to log in our workflow. Remember, clear communication is key in both coding and the classroom!
Line range hint
1-1: Class dismissed: Final thoughts on our workflow changesAlright, class, let's wrap up our lesson on GitHub Actions workflows. We've seen a small but important addition to our "Appsmith Server Workflow." Can anyone summarize what we learned today?
That's correct! We added a new step to log whether we're using a PostgreSQL build. This might seem like a small change, but in the world of software development, every bit of information can be crucial.
Remember, students, clear logging and good communication in your code are just as important as your math homework. They help us understand what's happening in our systems and make troubleshooting easier.
For your final assignment, I want you to think about how this change might impact our overall development process. How could knowing the database type for each build help us in the future?
Class dismissed! Don't forget to push your changes and always be curious about improving your workflows!
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
📒 Files selected for processing (1)
- .github/workflows/ci-test-custom-script.yml (1 hunks)
🧰 Additional context used
🪛 actionlint
.github/workflows/ci-test-custom-script.yml
203-203: workflow command "set-output" was deprecated. use
echo "{name}={value}" >> $GITHUB_OUTPUTinstead: https://docs.github.com/en/actions/using-workflows/workflow-commands-for-github-actions(deprecated-commands)
203-203: workflow command "set-output" was deprecated. use
echo "{name}={value}" >> $GITHUB_OUTPUTinstead: https://docs.github.com/en/actions/using-workflows/workflow-commands-for-github-actions(deprecated-commands)
203-203: workflow command "set-output" was deprecated. use
echo "{name}={value}" >> $GITHUB_OUTPUTinstead: https://docs.github.com/en/actions/using-workflows/workflow-commands-for-github-actions(deprecated-commands)
…add-logs-for-default-DB-url
Description
Summary by CodeRabbit
New Features
Bug Fixes
/test Sanity
🔍 Cypress test results
Caution
🔴 🔴 🔴 Some tests have failed.
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/11104222888
Commit: df82014
Cypress dashboard.
Tags: @tag.Sanity
Spec:
The following are new failures, please fix them before merging the PR:
- cypress/e2e/Regression/ClientSide/Git/ExistingApps/v1.9.24/DSCrudAndBindings_Spec.ts
List of identified flaky tests.Mon, 30 Sep 2024 11:01:27 UTC
Communication
Should the DevRel and Marketing teams inform users about this change?
Summary by CodeRabbit
New Features
Bug Fixes