fix: increase the content length to fix large file size not working.

[sondermanish]

Description

Tip

Add a TL;DR when the description is longer than 500 words or extremely technical (helps the content, marketing, and DevRel team).

Please also include relevant motivation and context. List any dependencies that are required for this change. Add links to Notion, Figma or any other documents that might be relevant to the PR.

Fixes #Issue Number
or
Fixes Issue URL

Warning

If no issue exists, please create an issue first, and check with the maintainers if the issue is valid.

Automation

/ok-to-test tags="@tag.Datasource"

🔍 Cypress test results

Tip

🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/10212521266
Commit: 3f4d4a7
Cypress dashboard.
Tags: @tag.Datasource
Spec:

---

Fri, 02 Aug 2024 09:02:19 UTC

Communication

Should the DevRel and Marketing teams inform users about this change?

• Yes
• No

Summary by CodeRabbit

• New Features

  • Enhanced configuration for handling multipart form data, allowing for the processing of larger files without data truncation.

• Improvements

  • Streamlined initialization of the data processing component, improving readability and maintainability.

[coderabbitai]

Important

Review skipped

Auto reviews are limited to specific labels.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Walkthrough

The recent updates to the DataUtils class enhance the configuration of the ObjectMapper for handling multipart form data. The constructor has been refactored for improved readability, consolidating configuration methods into a single fluent chain. A new constraint is also introduced to support larger file sizes, ensuring better data integrity during processing. These changes collectively strengthen the application's capability to manage multipart data efficiently while preserving existing functionalities.

Changes

File Path	Change Summary
app/server/appsmith-interfaces/src/main/java/com/appsmith/external/helpers/restApiUtils/helpers/DataUtils.java	Refactored ObjectMapper initialization for better readability and added constraints for larger data handling.

Poem

In the realm of data streams,
Where multipart magic gleams,
The ObjectMapper shines anew,
Handling files, both vast and true.
With constraints set, it takes the lead,
Ensuring every byte is freed! ✨

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 3b1c14a and 3f4d4a7.

Files selected for processing (1)

• app/server/appsmith-interfaces/src/main/java/com/appsmith/external/helpers/restApiUtils/helpers/DataUtils.java (2 hunks)

Additional comments not posted (3)

app/server/appsmith-interfaces/src/main/java/com/appsmith/external/helpers/restApiUtils/helpers/DataUtils.java (3)

12-12: Good job importing StreamReadConstraints.

This import is necessary for setting stream read constraints on the ObjectMapper.

---

87-88: Great job adding explanatory comments.

The comments provide clear context about why the stream read constraints are set, which is helpful for future developers.

---

84-93: Well done on configuring the ObjectMapper for large files.

The changes in the constructor to set stream read constraints are correctly implemented and necessary for handling large files without truncation.

However, ensure that these changes do not affect other parts of the application.

[subrata71]

I have a few concerns

1. With this setting it might consume more memory. Won't it have impact on the overall platform?
2. Will it lead to memory leakage for a certain period given that multiple large files are being uploaded?

[sondermanish]

@subrata71 It would take more memory for the time it's getting execute. but number of these cases is generally too low on our deployments, For customers who frequently use large files may see spike in memory.
I'm not sure how this could lead to memory leaks, this is basically increasing the acceptable limit of file size.
Although, if there is an existing memory leak we may start to notice since diff will be larger

[sondermanish]

added a task to increase observability of file size.