chore: Change the default value of isLoading in settings reducer to true

[dvj1988]

Description

This PR makes sure that the initial value of isLoading in the settings reducer is set to true.
This flag is used to conditionally render the loading component and the AdminSettings component in app/client/src/pages/AdminSettings/index.tsx. This change makes sure that the Admin Page components are not mounted and unmounted on initial render. The mouting and unmounting used to happen earlier because the flag switched from false => true => false.

Fixes #Issue Number
or
Fixes Issue URL

Warning

If no issue exists, please create an issue first, and check with the maintainers if the issue is valid.

Automation

/ok-to-test tags="@tag.Sanity"

🔍 Cypress test results

Tip

🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/9737924972
Commit: 553b867
Cypress dashboard.
Tags: @tag.Sanity

Communication

Should the DevRel and Marketing teams inform users about this change?

• Yes
• No

Summary by CodeRabbit

• Bug Fixes
  • Improved initial loading state of settings to enhance user experience during app startup.

[coderabbitai]

Walkthrough

This update modifies the initial state of the settings reducer within a client-side application. Specifically, the isLoading property of the SettingsReduxState has been initialized to true instead of false, likely indicating an initial state where the settings data is being loaded.

Changes

File Path	Change Summary
.../src/ce/reducers/settingsReducer.ts	isLoading in initialState changed from false to true

Poem

In the land of code, where changes tread,
The setting’s state now starts well-read,
From false to true, it hugs the load,
A tiny tweak, to streamline the road.
🌟 The settings wait, for data's cheer,
While rabbits code, without a fear. 🐇

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[dvj1988]

/build-deploy-preview skip-tests=true

[github-actions]

Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/9678906211.
Workflow: On demand build Docker image and deploy preview.
skip-tests: true.
env: ``.
PR: 34490.
recreate: .

[coderabbitai]

Actionable comments posted: 0

Outside diff range and nitpick comments (2)

app/client/src/ce/reducers/settingsReducer.ts (2)

Line range hint 52-52: Replace hasOwnProperty with Object.hasOwn().

Using Object.hasOwn() is recommended over hasOwnProperty for better safety and standard compliance.

- if (action.payload?.tenantConfiguration?.hasOwnProperty(key)) {
+ if (Object.hasOwn(action.payload?.tenantConfiguration, key)) {

---

Line range hint 71-71: Replace hasOwnProperty with Object.hasOwn().

As previously noted, Object.hasOwn() is safer and more compliant than hasOwnProperty.

- if (action.payload?.tenantConfiguration?.hasOwnProperty(key)) {
+ if (Object.hasOwn(action.payload?.tenantConfiguration, key)) {

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between f8f5ebb and 553b867.

Files selected for processing (1)

• app/client/src/ce/reducers/settingsReducer.ts (1 hunks)

Additional context used

Biome

app/client/src/ce/reducers/settingsReducer.ts

[error] 52-52: Do not access Object.prototype method 'hasOwnProperty' from target object. (lint/suspicious/noPrototypeBuiltins)

It's recommended using Object.hasOwn() instead of using Object.hasOwnProperty().
See MDN web docs for more details.

---

[error] 71-71: Do not access Object.prototype method 'hasOwnProperty' from target object. (lint/suspicious/noPrototypeBuiltins)

It's recommended using Object.hasOwn() instead of using Object.hasOwnProperty().
See MDN web docs for more details.

Additional comments not posted (1)

app/client/src/ce/reducers/settingsReducer.ts (1)

11-11: Change of default value for isLoading approved.

The change to set isLoading to true by default is straightforward. However, ensure that this does not lead to a confusing user experience by showing loading indicators where they aren't necessary.

[github-actions]

Deploy-Preview-URL: https://ce-34490.dp.appsmith.com