Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: refactor text and value to parsedText and rawText #33680

Merged
merged 1 commit into from
May 23, 2024

Conversation

jsartisan
Copy link
Contributor

@jsartisan jsartisan commented May 23, 2024

Minor refactor consistency with WDSInputWidget. This PR refactors "text" to parsedText and "value" to rawText so there is no confusion in what is what.

/ok-to-test tags="@tag.Anvil"

Tip

🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/9205775397
Commit: 527ec19
Cypress dashboard url: Click here!

Copy link
Contributor

coderabbitai bot commented May 23, 2024

Walkthrough

Walkthrough

The recent updates involve standardizing property names across widget-related files for clarity and consistency. The changes primarily focus on renaming text to parsedText and value to rawText within the affected components. These adjustments ensure a uniform naming convention within the WDSCurrencyInputWidget and WDSPhoneInputWidget classes and related files.

Changes

File Path Change Summary
.../WDSCurrencyInputWidget/.../autocompleteConfig.ts Renamed text to parsedText and value to rawText in autocompleteConfig object.
.../WDSCurrencyInputWidget/.../derived.js Updated variable names from text to parsedText within the value function.
.../WDSCurrencyInputWidget/.../index.tsx Refactored WDSCurrencyInputWidget class to utilize rawText and parsedText instead of value and text.
.../WDSPhoneInputWidget/.../autocompleteConfig.ts Renamed text to parsedText and value to rawText in autocompleteConfig object.
.../WDSPhoneInputWidget/.../index.tsx Updated WDSPhoneInputWidget class to incorporate rawText and parsedText properties, adjusting methods accordingly.

Recent Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits Files that changed from the base of the PR and between fa9d7f026039517ecfece0e6b04422ca75a62f3d and 527ec19.
Files selected for processing (5)
  • app/client/src/widgets/wds/WDSCurrencyInputWidget/config/autocompleteConfig.ts (1 hunks)
  • app/client/src/widgets/wds/WDSCurrencyInputWidget/widget/derived.js (1 hunks)
  • app/client/src/widgets/wds/WDSCurrencyInputWidget/widget/index.tsx (8 hunks)
  • app/client/src/widgets/wds/WDSPhoneInputWidget/config/autocompleteConfig.ts (1 hunks)
  • app/client/src/widgets/wds/WDSPhoneInputWidget/widget/index.tsx (6 hunks)
Files skipped from review as they are similar to previous changes (5)
  • app/client/src/widgets/wds/WDSCurrencyInputWidget/config/autocompleteConfig.ts
  • app/client/src/widgets/wds/WDSCurrencyInputWidget/widget/derived.js
  • app/client/src/widgets/wds/WDSCurrencyInputWidget/widget/index.tsx
  • app/client/src/widgets/wds/WDSPhoneInputWidget/config/autocompleteConfig.ts
  • app/client/src/widgets/wds/WDSPhoneInputWidget/widget/index.tsx

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@jsartisan jsartisan added the ok-to-test Required label for CI label May 23, 2024
@github-actions github-actions bot added the skip-changelog Adding this label to a PR prevents it from being listed in the changelog label May 23, 2024
@jsartisan jsartisan requested a review from KelvinOm May 23, 2024 05:58
@jsartisan jsartisan enabled auto-merge (squash) May 23, 2024 06:00
@jsartisan jsartisan force-pushed the chore/refactor-phone-currency-input branch from fa9d7f0 to 527ec19 Compare May 23, 2024 08:16
@jsartisan jsartisan added ok-to-test Required label for CI and removed ok-to-test Required label for CI labels May 23, 2024
@jsartisan jsartisan merged commit 9a9e97c into release May 23, 2024
71 checks passed
@jsartisan jsartisan deleted the chore/refactor-phone-currency-input branch May 23, 2024 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ok-to-test Required label for CI skip-changelog Adding this label to a PR prevents it from being listed in the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants