test: removing unused commands from Commands file #33617

NandanAnantharamu · 2024-05-21T10:20:09Z

RCA: There are many unused commands within commands.js file

Solution:
Checked the commands in both CE and EE repository and we are removing those commands whcih are not used in any tests as part of cleanup activity

/ok-to-test tags="@tag.All"

Warning

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/9177375213
Commit: 925d758
Cypress dashboard url: Click here!
It seems like no tests ran 😔. We are not able to recognize it, please check workflow here.

coderabbitai · 2024-05-21T10:21:11Z

Walkthrough

The recent update involves moving a test spec file from Fork_Template_spec.js in cypress/e2e/Regression/ClientSide/Templates to Postgres_Spec.js in cypress/e2e/Regression/ServerSide/QueryPane.

Changes

Files	Change Summary
`app/client/cypress/support/commands.js`	Moved test spec file from `Fork_Template_spec.js` in `cypress/e2e/Regression/ClientSide/Templates` to `Postgres_Spec.js` in `cypress/e2e/Regression/ServerSide/QueryPane`.

Recent Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between efbdd30 and 8a391b7.

Files selected for processing (1)

app/client/cypress/support/commands.js (26 hunks)

Additional comments not posted (1)

app/client/cypress/support/commands.js (1)
1462-1479: The implementation of the paste command looks correct. Consider adding a comment explaining why the last character is typed separately, as this might not be immediately obvious to other developers.
+    // The last character is typed separately to trigger specific UI behaviors that might depend on keypress events.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai generate interesting stats about this repository and render them as a table.
- @coderabbitai show all the console.log statements in this repository.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

NandanAnantharamu · 2024-05-21T15:57:17Z

/ci-test-limit

github-actions · 2024-05-21T15:57:49Z

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/9177629151.
Cypress dashboard
PR: #33617.

coderabbitai

Actionable comments posted: 2

Outside diff range and nitpick comments (1)

app/client/cypress/limited-tests.txt (1)
Line range hint 7-7: Consider adding the article "the" before "entire suite" for grammatical correctness.
-#ci-test-limit uses this file to run minimum of specs. Do not run entire suite with this command.
+#ci-test-limit uses this file to run minimum of specs. Do not run the entire suite with this command.

coderabbitai · 2024-05-21T16:01:48Z

app/client/cypress/limited-tests.txt

@@ -1,5 +1,5 @@
 # To run only limited tests - give the spec names in below format:


Consider adding the article "the" before "below format" for grammatical correctness.

-# To run only limited tests - give the spec names in below format: +# To run only limited tests - give the spec names in the below format:

Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.

Suggested change

# To run only limited tests - give the spec names in below format:

# To run only limited tests - give the spec names in the below format:

coderabbitai · 2024-05-21T16:01:49Z

app/client/cypress/support/commands.js

+Cypress.Commands.add(
+  "paste",
+  {
+    prevSubject: true,
+    element: true,
+  },
+  ($element, text) => {
+    const subString = text.slice(0, -1);
+    const lastChar = text.slice(-1);
+
+    cy.get(commonlocators.entityExplorersearch)
+      .clear({ force: true })
+      .click({ force: true })
+      .then(() => {
+        $element.text(subString);
+        $element.val(subString);
+        cy.get($element).type(lastChar);
+      });
+  },
+);


The implementation of the paste command looks correct. Consider adding a comment explaining why the last character is typed separately, as this might not be immediately obvious to other developers.

+ // The last character is typed separately to trigger specific UI behaviors that might depend on keypress events.

Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.

Suggested change

Cypress.Commands.add(

"paste",

{

prevSubject: true,

element: true,

},

($element, text) => {

const subString = text.slice(0, -1);

const lastChar = text.slice(-1);

cy.get(commonlocators.entityExplorersearch)

.clear({ force: true })

.click({ force: true })

.then(() => {

$element.text(subString);

$element.val(subString);

cy.get($element).type(lastChar);

});

},

);

Cypress.Commands.add(

"paste",

{

prevSubject: true,

element: true,

},

($element, text) => {

const subString = text.slice(0, -1);

const lastChar = text.slice(-1);

// The last character is typed separately to trigger specific UI behaviors that might depend on keypress events.

cy.get(commonlocators.entityExplorersearch)

.clear({ force: true })

.click({ force: true })

.then(() => {

$element.text(subString);

$element.val(subString);

cy.get($element).type(lastChar);

});

},

);

NandanAnantharamu · 2024-05-21T16:44:39Z

/ci-test-limit runId=9177629151

github-actions · 2024-05-21T16:45:10Z

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/9178258212.
Cypress dashboard
PR: #33617.

NandanAnantharamu · 2024-05-21T17:19:34Z

/ci-test-limit runId=9177629151

github-actions · 2024-05-21T17:20:06Z

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/9178713562.
Cypress dashboard
PR: #33617.

github-actions · 2024-05-21T17:28:14Z

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/9178713562.
Cypress dashboard url: Click here!
All cypress tests have passed 🎉🎉🎉

trishaanand · 2024-05-22T04:47:50Z

app/client/cypress/support/commands.js

@@ -2110,3 +1459,21 @@ Cypress.Commands.add(
    cy.get(tooltipSelector).should("be.visible").and("contain", expectedText);
  },
 );
+
+Cypress.Commands.add(


Why did we spend time re-writing paste command?

i had mistakenly removed this commad i added it back, its not rewritten. I wasnt able to figure out as it was a chained command

removing unused commands from Commands file

4c9a62b

NandanAnantharamu added the ok-to-test Required label for CI label May 21, 2024

github-actions bot added skip-changelog Adding this label to a PR prevents it from being listed in the changelog Test labels May 21, 2024

trishaanand previously approved these changes May 21, 2024

View reviewed changes

Merge branch 'release' into test/removeUnusedCommands

925d758

NandanAnantharamu added ok-to-test Required label for CI and removed ok-to-test Required label for CI labels May 21, 2024

updated commands file

efbdd30

NandanAnantharamu dismissed trishaanand’s stale review via efbdd30 May 21, 2024 15:56

coderabbitai bot reviewed May 21, 2024

View reviewed changes

added right paste command which is in use

277ecc6

reverted limited test file

8a391b7

NandanAnantharamu requested a review from trishaanand May 22, 2024 01:46

trishaanand reviewed May 22, 2024

View reviewed changes

trishaanand approved these changes May 22, 2024

View reviewed changes

trishaanand merged commit 03f45ec into release May 22, 2024
13 checks passed

trishaanand deleted the test/removeUnusedCommands branch May 22, 2024 06:08

coderabbitai bot mentioned this pull request Oct 23, 2024

test: fix datepicker tests #37042

Merged

coderabbitai bot mentioned this pull request Nov 5, 2024

test: Analyse API Edit spec #37240

Closed

This was referenced Dec 12, 2024

test: adding tests for JsObjects regression #38103

Closed

test: adding tests for jsobject regression tests #38214

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

test: removing unused commands from Commands file #33617

test: removing unused commands from Commands file #33617

NandanAnantharamu commented May 21, 2024 •

edited by github-actions bot

Loading

coderabbitai bot commented May 21, 2024 •

edited

Loading

Walkthrough

Changes

Chat

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configration File (`.coderabbit.yaml`)

Documentation and Community

NandanAnantharamu commented May 21, 2024

github-actions bot commented May 21, 2024

coderabbitai bot left a comment

coderabbitai bot May 21, 2024

coderabbitai bot May 21, 2024

NandanAnantharamu commented May 21, 2024

github-actions bot commented May 21, 2024

NandanAnantharamu commented May 21, 2024

github-actions bot commented May 21, 2024

github-actions bot commented May 21, 2024

trishaanand May 22, 2024

NandanAnantharamu May 22, 2024

		@@ -1,5 +1,5 @@
		# To run only limited tests - give the spec names in below format:

test: removing unused commands from Commands file #33617

test: removing unused commands from Commands file #33617

Conversation

NandanAnantharamu commented May 21, 2024 • edited by github-actions bot Loading

coderabbitai bot commented May 21, 2024 • edited Loading

Walkthrough

Changes

Chat

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configration File (.coderabbit.yaml)

Documentation and Community

NandanAnantharamu commented May 21, 2024

github-actions bot commented May 21, 2024

coderabbitai bot left a comment

Choose a reason for hiding this comment

coderabbitai bot May 21, 2024

Choose a reason for hiding this comment

coderabbitai bot May 21, 2024

Choose a reason for hiding this comment

NandanAnantharamu commented May 21, 2024

github-actions bot commented May 21, 2024

NandanAnantharamu commented May 21, 2024

github-actions bot commented May 21, 2024

github-actions bot commented May 21, 2024

trishaanand May 22, 2024

Choose a reason for hiding this comment

NandanAnantharamu May 22, 2024

Choose a reason for hiding this comment

NandanAnantharamu commented May 21, 2024 •

edited by github-actions bot

Loading

coderabbitai bot commented May 21, 2024 •

edited

Loading

CodeRabbit Configration File (`.coderabbit.yaml`)