Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: cypress strings replaced with var names #33469

Merged
merged 5 commits into from
May 15, 2024

Conversation

ayushpahwa
Copy link
Contributor

@ayushpahwa ayushpahwa commented May 15, 2024

Description

Updated cypress tests by replacing hard coded strings with variables. Also removed unused commented code from DebuggerHelper and an extra var

Fixes #33256

Automation

/ok-to-test tags="@tag.IDE"

🔍 Cypress test results

Tip

🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/9092019864
Commit: e66c44b
Cypress dashboard url: Click here!

Communication

Should the DevRel and Marketing teams inform users about this change?

  • Yes
  • No

Copy link
Contributor

coderabbitai bot commented May 15, 2024

Walkthrough

Walkthrough

The recent changes primarily focus on enhancing the maintainability and clarity of Cypress tests and UI components by leveraging environment variables for debugger messages. This involves updating assertions and tab titles to use dynamically created messages from Cypress.env and constants defined in the messages.ts file. These changes ensure consistency across the codebase and make it easier to manage message strings.

Changes

File Path Change Summary
.../OtherUIFeatures/ApiError_spec.ts
.../OtherUIFeatures/EntityBottomBar_spec.ts
Updated assertions for selected tabs in Cypress tests to use values from Cypress.env for debugger errors and responses.
.../support/Pages/DebuggerHelper.ts Removed commented-out code and simplified the LogStateContains method by removing the optional index parameter.
.../constants/messages.ts Added a new constant DEBUGGER_RESPONSE for debugger response messages.
.../components/editorComponents/ApiResponseView.tsx
.../components/editorComponents/JSResponseView.tsx
.../Editor/QueryEditor/EditorJSONtoForm.tsx
.../Editor/QueryEditor/QueryDebuggerTabs.tsx
Changed tab titles to use dynamically created messages using DEBUGGER_RESPONSE.

Assessment against linked issues

Objective Addressed Explanation
Cleanup test infra
Add test for running test on temporal
Check for test trigger with and without payload
Check for persistence of payload between reloads

Recent Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits Files that changed from the base of the PR and between 523d8cb and e66c44b.
Files selected for processing (2)
  • app/client/cypress/e2e/Regression/ClientSide/OtherUIFeatures/ApiError_spec.ts (1 hunks)
  • app/client/cypress/e2e/Regression/ClientSide/OtherUIFeatures/EntityBottomBar_spec.ts (7 hunks)
Files skipped from review as they are similar to previous changes (2)
  • app/client/cypress/e2e/Regression/ClientSide/OtherUIFeatures/ApiError_spec.ts
  • app/client/cypress/e2e/Regression/ClientSide/OtherUIFeatures/EntityBottomBar_spec.ts

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@ayushpahwa ayushpahwa requested a review from mohanarpit May 15, 2024 07:20
@github-actions github-actions bot added skip-changelog Adding this label to a PR prevents it from being listed in the changelog Task A simple Todo Workflows Product Issues related to the workflows product Workflows Pod Issues that the workflows team owns labels May 15, 2024
@ayushpahwa ayushpahwa added the ok-to-test Required label for CI label May 15, 2024
@ayushpahwa ayushpahwa requested a review from ankitakinger May 15, 2024 07:55
@ayushpahwa ayushpahwa added ok-to-test Required label for CI and removed ok-to-test Required label for CI labels May 15, 2024
@ayushpahwa ayushpahwa merged commit 43d61f7 into release May 15, 2024
44 checks passed
@ayushpahwa ayushpahwa deleted the fix/cypress-var-names branch May 15, 2024 08:28
@coderabbitai coderabbitai bot mentioned this pull request Nov 11, 2024
2 tasks
@coderabbitai coderabbitai bot mentioned this pull request Dec 5, 2024
2 tasks
@coderabbitai coderabbitai bot mentioned this pull request Jan 2, 2025
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ok-to-test Required label for CI skip-changelog Adding this label to a PR prevents it from being listed in the changelog Task A simple Todo Workflows Pod Issues that the workflows team owns Workflows Product Issues related to the workflows product
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Task]: Cypress tests for workflow test run
2 participants