fix: graphQL bindings issue resolved (#32760) #32785
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolved issue with graphQL, where if we create a graphQL with a binding and run such query, it returns with error response saying the query execution has timed out. A user had raised this issue here.
The issue was not at all reproducible on local, but It was continuously erroring out on production, release and even DPs. From the logs, we can see that issue was with
GraphQLDataTypeUtils.java
class. This class was somehow not getting initialised. This was due to recent changes made in PR, where the version for package was updated to v2.17.0, on local it was compiling properly but on release, production and other builds, it still seems to be referencing to the older version of it, we do not know the reason of it right now, we should further investigate this. But since this was a critical issue and we need to get user unblocked, we are going ahead with an alternate fix where we have moved the initialisation of objectMapper to serialisationUtils.java file.US
https://countries.trevorblades.com/
Fixes #32748
or
Fixes
Issue URL
Warning
If no issue exists, please create an issue first, and check with the
maintainers if the issue is valid.
/ok-to-test tags="@tag.All"
Tip
🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
Workflow run:
https://github.com/appsmithorg/appsmith/actions/runs/8735651316
Commit: a03f29f
Cypress dashboard url: Click here!
Description
Tip
Add a TL;DR when the description is longer than 500 words or extremely technical (helps the content, marketing, and DevRel team).
Please also include relevant motivation and context. List any dependencies that are required for this change. Add links to Notion, Figma or any other documents that might be relevant to the PR.
Fixes #
Issue Number
or
Fixes
Issue URL
Warning
If no issue exists, please create an issue first, and check with the maintainers if the issue is valid.
Automation
/ok-to-test tags=""
🔍 Cypress test results
Caution
If you modify the content in this section, you are likely to disrupt the CI result for your PR.
Communication
Should the DevRel and Marketing teams inform users about this change?