-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Remove unused services #30292
Conversation
/ok-to-test tags="@tag.Sanity" |
Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/7585975089. |
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/7585975089. |
All Cypress tests run on EE PR and passed. |
WalkthroughWalkthroughThe overall change seems to be the removal of features and integrations related to RapidAPI and the marketplace from an application platform. This includes the removal of API keys, configurations, routes, UI components, Redux actions, sagas, and other related code references. Additionally, there are minor whitespace adjustments and the addition of Algolia Search configurations, suggesting a pivot in the service offerings or a refactoring to streamline the application. Changes
Note: For brevity, file paths have been shortened using ellipsis ( Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
@sharat87 In the next PR, do we also want to write migrations to delete the unused collections? Or do you believe that's not important right now? |
@mohanarpit, thanks. I don't think its too important, but I do intend to look at it. If we do it though, I'd prefer it be an async migration, in that the server being ready shouldn't depend on this migration completing, or even be successful. If we can do it in that async fashion, only then will we have that migration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
At long last! Thanks for this <3
I've been doing this in pieces bit by bit, not to rock the boat too much too fast, but it's taking too long, and too much effort. Instead opting for a rip-the-bandaid style, hopefully without the pain.
Summary by CodeRabbit
New Features
Removed Features
Bug Fixes
index.html
.Documentation
.env.example
files to reflect the removal of marketplace configurations.Refactor
GET
andDELETE
calls.Style
Chores
Please note that the removal of the marketplace features may impact workflows that relied on these integrations. Users are encouraged to explore alternative solutions or contact support for assistance.