Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Remove unused services #30292

Merged
merged 5 commits into from
Jan 23, 2024
Merged

chore: Remove unused services #30292

merged 5 commits into from
Jan 23, 2024

Conversation

sharat87
Copy link
Member

@sharat87 sharat87 commented Jan 15, 2024

I've been doing this in pieces bit by bit, not to rock the boat too much too fast, but it's taking too long, and too much effort. Instead opting for a rip-the-bandaid style, hopefully without the pain.

Summary by CodeRabbit

  • New Features

    • Integrated Algolia Search for improved documentation search capabilities.
  • Removed Features

    • Discontinued support for RapidAPI integrations and marketplace features.
    • Removed 3P (Third Party) provider templates and related components.
    • Eliminated specific marketplace-related routes and configurations.
  • Bug Fixes

    • Addressed issues with unnecessary whitespace in index.html.
  • Documentation

    • Updated .env.example files to reflect the removal of marketplace configurations.
  • Refactor

    • Simplified API fetching by consolidating GET and DELETE calls.
    • Streamlined Redux state management by removing unused action constants and reducers.
    • Enhanced test reliability by updating sagas and removing outdated tests.
  • Style

    • Cleaned up code formatting for better readability and maintainability.
  • Chores

    • Removed unused code and dependencies related to deprecated marketplace functionality.

Please note that the removal of the marketplace features may impact workflows that relied on these integrations. Users are encouraged to explore alternative solutions or contact support for assistance.

@github-actions github-actions bot added the skip-changelog Adding this label to a PR prevents it from being listed in the changelog label Jan 15, 2024
@sharat87
Copy link
Member Author

/ok-to-test tags="@tag.Sanity"

Copy link

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/7585975089.
Workflow: Appsmith External Integration Test Workflow.
Tags: @tag.Sanity.

Copy link

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/7585975089.
Commit: ``.
Cypress dashboard url: Click here!
All cypress tests have passed 🎉🎉🎉

@sharat87
Copy link
Member Author

All Cypress tests run on EE PR and passed.

@sharat87 sharat87 marked this pull request as ready for review January 22, 2024 03:43
Copy link
Contributor

coderabbitai bot commented Jan 22, 2024

Walkthrough

Walkthrough

The overall change seems to be the removal of features and integrations related to RapidAPI and the marketplace from an application platform. This includes the removal of API keys, configurations, routes, UI components, Redux actions, sagas, and other related code references. Additionally, there are minor whitespace adjustments and the addition of Algolia Search configurations, suggesting a pivot in the service offerings or a refactoring to streamline the application.

Changes

File(s) Summary of Changes
.env.example, .../nginx-app.conf.template, start-https.sh, .../docker.env.example Removed configurations related to RapidAPI and the marketplace.
.../cypress/support/commands.js, .../public/index.html Updated Cypress commands by removing intercepts for marketplace-related features; whitespace adjustments in HTML file.
.../jest.config.js, .../src/api/PluginApi.ts, .../src/ce/RouteBuilder.ts, .../src/ce/api/ApiUtils.ts, .../src/ce/configs/index.ts, .../src/ce/configs/types.ts, .../src/ce/constants/ReduxActionConstants.tsx, .../src/ce/constants/routes/appRoutes.ts, .../src/ce/pages/Editor/IDE/MainPane/useRoutes.ts, .../src/ce/pages/Editor/routes.tsx, .../src/ce/reducers/index.tsx, .../src/ce/reducers/uiReducers/index.tsx, .../src/ce/sagas/index.tsx, .../src/ce/selectors/applicationSelectors.tsx, .../src/components/editorComponents/PartialImportExport/PartialExportModal/unitTestUtils.ts, .../src/entities/Action/index.ts, .../src/pages/Editor/APIEditor/Editor.tsx, .../src/selectors/editorSelectors.tsx, .../src/serviceWorker.js, .../test/sagas.ts Removed all references and features related to RapidAPI and marketplace, including enums, routes, UI components, Redux actions, sagas, selectors, and service worker cache strategies.
.../appsmith-interfaces/.../ActionCE_DTO.java, .../appsmith-server/.../FieldNameCE.java, .../appsmith-server/.../UrlCE.java, .../appsmith-server/.../RestApiImportController.java, .../appsmith-server/.../RestApiImportControllerCE.java, .../appsmith-server/.../Action.java, .../appsmith-server/.../Plugin.java, .../appsmith-server/.../NewActionCE.java, .../appsmith-server/.../AppsmithError.java, .../appsmith-server/.../AppsmithErrorCode.java, .../appsmith-server/.../NewActionServiceCEImpl.java, .../appsmith-server/.../NewActionServiceImpl.java, .../appsmith-server/.../UserChangedHandlerImpl.java, .../appsmith-server/.../UserChangedHandlerCEImpl.java, .../appsmith-server/.../RefactoringServiceCETest.java, .../appsmith-server/.../NewActionServiceUnitTest.java Significant removal of marketplace and RapidAPI related code from server-side classes, error codes, DTOs, and tests.
deploy/docker/fs/opt/appsmith/templates/docker.env.sh Removed RapidAPI related declarations, added Algolia Search configurations.

Note: For brevity, file paths have been shortened using ellipsis (...).

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit-tests for this file.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit tests for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository from git and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit tests.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

@mohanarpit
Copy link
Member

@sharat87 In the next PR, do we also want to write migrations to delete the unused collections? Or do you believe that's not important right now?

@sharat87
Copy link
Member Author

@mohanarpit, thanks. I don't think its too important, but I do intend to look at it. If we do it though, I'd prefer it be an async migration, in that the server being ready shouldn't depend on this migration completing, or even be successful. If we can do it in that async fashion, only then will we have that migration.

Copy link
Contributor

@nidhi-nair nidhi-nair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At long last! Thanks for this <3

@sharat87 sharat87 merged commit 92993cc into release Jan 23, 2024
19 checks passed
@sharat87 sharat87 deleted the chore/purge branch January 23, 2024 00:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip-changelog Adding this label to a PR prevents it from being listed in the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants