Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: The empty space is clickable when the user edits the App name or the organisation name #9643

Open
1 task done
YogeshJayaseelan opened this issue Dec 8, 2021 · 4 comments
Assignees
Labels
Bug Something isn't working Home Page Issues related to the application home page Inviting Contribution Issues that we would like contributions to Low effort Takes 1-2 days Low An issue that is neither critical nor breaks a user flow Needs Triaging Needs attention from maintainers to triage Platform Administration Pod Issues related to platform administration & management Production Workspace Product Issues related to workspaces

Comments

@YogeshJayaseelan
Copy link
Contributor

YogeshJayaseelan commented Dec 8, 2021

Is there an existing issue for this?

  • I have searched the existing issues

Current Behavior

It is observed that form the homepage when the user tries to edit the application name or the organization name by clicking on the pencil icon and after editing the name when the user clicks on the empty space(where the pencil icon was displayed initially) the changes gets saved.

Expected result:
Clicking on pencil icon should show save icon and cancel icon so that user may click on save icon to make the changes or cancel icon to un-save changes

Actual result:
Currently empty space is displayed and which is clickable

LOOM DEMO

Steps To Reproduce

1.Launch appmsith app in release or prod environment
2.From the homepage click on the three dots from any existing app or the organization name
3.click on the pencil icon
4.Edit the name and click on the empty space - where the pencil icon was displayed initially and observe

Environment

Production

Version

Cloud

@YogeshJayaseelan YogeshJayaseelan added Bug Something isn't working Home Page Issues related to the application home page Low An issue that is neither critical nor breaks a user flow Needs Triaging Needs attention from maintainers to triage labels Dec 8, 2021
@github-actions github-actions bot added Platform Administration Pod Issues related to platform administration & management Platform Pod labels Dec 8, 2021
@github-actions github-actions bot added Billing & Licensing Product Issues pertaining to licensing, billing and usage across self serve and enterprise customers and removed Platform Administration Pod Issues related to platform administration & management labels Feb 29, 2024
@Nikhil-Nandagopal Nikhil-Nandagopal added the Workspace Product Issues related to workspaces label Aug 5, 2024
@github-actions github-actions bot added Platform Administration Pod Issues related to platform administration & management and removed Billing & Licensing Product Issues pertaining to licensing, billing and usage across self serve and enterprise customers labels Aug 5, 2024
@riteshkew riteshkew added Low effort Takes 1-2 days Inviting Contribution Issues that we would like contributions to labels Oct 4, 2024
@Sai6347
Copy link

Sai6347 commented Oct 7, 2024

Hi @YogeshJayaseelan, @Nikhil-Nandagopal, @riteshkew
I would like to work on this issue, I am planning to add tick icon for save and cross icon for cancel. Is it fine or do you have any suggestions or refer any icons or buttons i could use in place of save and cancel.

@riteshkew
Copy link
Contributor

riteshkew commented Oct 7, 2024

@Sai6347 This does not seem like an icon issue but more of how the \div containing the icon was defined. Please go ahead if you are planning to look into this issue. Do reference the PR to this issue for better tracking.

@Sai6347
Copy link

Sai6347 commented Oct 7, 2024

@Sai6347 This does not seem like an icon issue but more of how the \div containing the icon was defined. Please go ahead if you are planning to look into this issue. Do reference the PR to this issue for better tracking.

@riteshkew ok thanks for confirmation, i will work on it.

Sai6347 added a commit to Sai6347/appsmith that referenced this issue Oct 15, 2024
@Sai6347
Copy link

Sai6347 commented Oct 17, 2024

Hi @riteshkew, can you please review this PR or assign someone to review it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working Home Page Issues related to the application home page Inviting Contribution Issues that we would like contributions to Low effort Takes 1-2 days Low An issue that is neither critical nor breaks a user flow Needs Triaging Needs attention from maintainers to triage Platform Administration Pod Issues related to platform administration & management Production Workspace Product Issues related to workspaces
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants