Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] : Support Currency as a new column in the table widget #5632

Closed
Tracked by #2860
somangshu opened this issue Jul 6, 2021 · 2 comments · Fixed by #27819
Closed
Tracked by #2860

[Feature] : Support Currency as a new column in the table widget #5632

somangshu opened this issue Jul 6, 2021 · 2 comments · Fixed by #27819
Assignees
@sbalaji1192
Labels
Enhancement New feature or request Needs Design needs design or changes to design QA Needs QA attention Table Widget Test Plan Approved Manual/Cypress tests covers changes made on the PR. Else, add skip-testPlan label if not applicable Widgets Product This label groups issues related to widgets

Comments

@somangshu
Copy link
Contributor

somangshu commented Jul 6, 2021 •
edited by ame-appsmith
Loading

Objective:

Introduce a new column type currency in the table widget.

Requirement:

Title Description Comment
Column properties Just like button properties this will appear
Auto format The value computed in the currency column will be auto formatted -
Currency symbol The user will be provided a dropdown to select the currency of there choice -
Decimals Precision point for the computed value -

Front logo Front conversations
@somangshu somangshu mentioned this issue Jul 6, 2021
Closed
16 tasks
@somangshu somangshu added Table Widget Task A simple Todo labels Jul 6, 2021
@github-actions github-actions bot added Widgets Product This label groups issues related to widgets UI Building Pod labels Jul 6, 2021
@somangshu somangshu added Enhancement New feature or request and removed Task A simple Todo labels Jul 6, 2021
@somangshu somangshu changed the title 6. Currency column Currency column Jul 6, 2021
vibhandikyash added a commit that referenced this issue Sep 22, 2021
@vibhandikyash
fix : #5632 added new column type - currency
1e7dcdb
@vibhandikyash vibhandikyash mentioned this issue Sep 23, 2021
Closed
7 tasks
@dilippitchika dilippitchika changed the title Currency column [Feature] : Support Currency as a new column in the table widget May 9, 2022
@GreenFlux
Copy link

Another user in Discord is requesting this feature:
https://discord.com/channels/725602949748752515/1076320585002532976

@GreenFlux GreenFlux mentioned this issue Apr 2, 2023
Closed
1 task
@keyurparalkar keyurparalkar added the Needs Design needs design or changes to design label Jul 4, 2023
@keyurparalkar
Copy link
Contributor

User journey

  • Displaying value: Value should be formatted according to locale with currency symbol.
    • Decimal formatting precision
    • Cell wrapping
  • Sorting, filtering and searching:
    • Sorting should be done as number.
    • Filtering rules should be similar to number column type.
      - Filter by currency symbol
      - Exiting number filters
    • Searching similar to the exiting.

Dev Journey

  • Displaying value: Value should be formatted according to locale with currency symbol.
    • Decimal formatting precision
    • Computed value has to be a number.
    • Currency change dropdown field
    • Cell wrapping
    • isVisible
    • Style properties should be same as number.
  • Editing:
    • Mark column editable. currentRow.
    • Validations that are present in currency input widget. All validations should have access to currentRow.
    • Currency editing experience we need design.
    • Events:
      • onChange: Should trigger when moving from editing to edited state.

@sbalaji1192 sbalaji1192 self-assigned this Oct 6, 2023
@sbalaji1192 sbalaji1192 mentioned this issue Oct 6, 2023
Merged
20 tasks
@laveena-en laveena-en added the Test Plan Approved Manual/Cypress tests covers changes made on the PR. Else, add skip-testPlan label if not applicable label Nov 3, 2023
somangshu pushed a commit that referenced this issue Nov 6, 2023
feat: Table widget currency column (#27819)
694b170 
## Description
Adds a new currency column type on the table widget.

#### PR fixes following issue(s)
Fixes #5632 
> if no issue exists, please create an issue and ask the maintainers
about this first
>
>
#### Media
> A video or a GIF is preferred. when using Loom, don’t embed because it
looks like it’s a GIF. instead, just link to the video
>
>
#### Type of change

- New feature (non-breaking change which adds functionality)
>
>
>
## Testing
>
#### How Has This Been Tested?
> Please describe the tests that you ran to verify your changes. Also
list any relevant details for your test configuration.
> Delete anything that is not relevant
- [x] Manual
- [ ] JUnit
- [ ] Jest
- [x] Cypress
>
>
#### Test Plan
> https://github.com/appsmithorg/TestSmith/issues/2447
>
>
#### Issues raised during DP testing
> Link issues raised during DP testing for better visiblity and tracking
(copy link from comments dropped on this PR)
>
>
>
## Checklist:
#### Dev activity
- [x] My code follows the style guidelines of this project
- [x] I have performed a self-review of my own code
- [x] I have commented my code, particularly in hard-to-understand areas
- [x] I have made corresponding changes to the documentation
- [x] My changes generate no new warnings
- [x] I have added tests that prove my fix is effective or that my
feature works
- [x] New and existing unit tests pass locally with my changes
- [ ] PR is being merged under a feature flag


#### QA activity:
- [ ] [Speedbreak
features](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#speedbreakers-)
have been covered
- [ ] Test plan covers all impacted features and [areas of
interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans#areas-of-interest-)
- [ ] Test plan has been peer reviewed by project stakeholders and other
QA members
- [ ] Manually tested functionality on DP
- [ ] We had an implementation alignment call with stakeholders post QA
Round 2
- [ ] Cypress test cases have been added and approved by SDET/manual QA
- [ ] Added `Test Plan Approved` label after Cypress tests were reviewed
- [ ] Added `Test Plan Approved` label after JUnit tests were reviewed
@appsmith-bot appsmith-bot added the QA Needs QA attention label Nov 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sbalaji1192 sbalaji1192

Labels
Enhancement New feature or request Needs Design needs design or changes to design QA Needs QA attention Table Widget Test Plan Approved Manual/Cypress tests covers changes made on the PR. Else, add skip-testPlan label if not applicable Widgets Product This label groups issues related to widgets
Projects
None yet
Milestone
No milestone