Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: "Show bindings" menu does not show up in split pane mode #38547

Closed
1 task done
shadabbuchh opened this issue Jan 9, 2025 · 0 comments · Fixed by #38553
Closed
1 task done

[Bug]: "Show bindings" menu does not show up in split pane mode #38547

shadabbuchh opened this issue Jan 9, 2025 · 0 comments · Fixed by #38553
Assignees
@nerbos @hetunandu
Labels
Bug Something isn't working IDE Navigation Issues/feature requests related to IDE navigation, and context switching IDE Pod Issues that new developers face while exploring the IDE IDE Product Issues related to the IDE Product Medium Issues that frustrate users due to poor UX Needs Triaging Needs attention from maintainers to triage Production QA Needs QA attention Regressed Scenarios that were working before but have now regressed

Comments

@shadabbuchh
Copy link
Contributor

Is there an existing issue for this?

  • I have searched the existing issues

Description

In split pane mode when I click on Show bindingsfor JS objects or queries, nothing happens. This is working fine in standard view.

Steps To Reproduce

  1. Switch to split pane view.
  2. For a query/JS Object in list view, click on the 3 dots.
  3. Click on Show bindings.

Expected: The menu for bindings should show up.

Public Sample App

No response

Environment

Production

Severity

Medium (Frustrating UX)

Issue video log

https://jam.dev/c/97db2b91-c77a-4f84-8ae1-72e3dc93bade

Version

Cloud
@shadabbuchh shadabbuchh added Bug Something isn't working Production Regressed Scenarios that were working before but have now regressed Needs Triaging Needs attention from maintainers to triage Medium Issues that frustrate users due to poor UX IDE Navigation Issues/feature requests related to IDE navigation, and context switching labels Jan 9, 2025
@github-actions github-actions bot added IDE Product Issues related to the IDE Product IDE Pod Issues that new developers face while exploring the IDE labels Jan 9, 2025
@hetunandu hetunandu mentioned this issue Jan 9, 2025
Merged
2 tasks
@appsmith-bot appsmith-bot added the QA Needs QA attention label Jan 9, 2025
@shadabbuchh shadabbuchh mentioned this issue Jan 10, 2025
Merged
2 tasks
shadabbuchh added a commit that referenced this issue Jan 13, 2025
@shadabbuchh
test: validate 'Show Bindings' menu for queries & JS Objects in split…
635de37 
…-pane (#38577)

## Description
This PR introduces test cases to validate the visibility and correctness
of the "Show Bindings" menu when working with JavaScript Objects and API
queries in the split-pane mode. It ensures that the bindings are
displayed as expected.

Tests: #38547

## Automation

/ok-to-test tags="@tag.Datasource, @tag.Sanity, @tag.JS"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/12708509894>
> Commit: 91840c0
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=12708509894&attempt=1"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.Datasource, @tag.Sanity, @tag.JS`
> Spec:
> <hr>Fri, 10 Jan 2025 12:29:18 UTC
<!-- end of auto-generated comment: Cypress test results  -->


## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [x] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

- **New Features**
- Added automated tests for validating the "Show Bindings" menu in split
pane mode.
	- Introduced new locators for list toggle and bindings menu.

- **Tests**
- Created test cases for checking "Show Bindings" functionality for
JavaScript Objects and API queries.

- **Chores**
- Updated test configurations to focus on specific test cases and
modified locator references in support files.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
github-actions bot pushed a commit to Zeral-Zhang/appsmith that referenced this issue Feb 7, 2025
@shadabbuchh
test: validate 'Show Bindings' menu for queries & JS Objects in split…
80ecc3f 
…-pane (appsmithorg#38577)

## Description
This PR introduces test cases to validate the visibility and correctness
of the "Show Bindings" menu when working with JavaScript Objects and API
queries in the split-pane mode. It ensures that the bindings are
displayed as expected.

Tests: appsmithorg#38547

## Automation

/ok-to-test tags="@tag.Datasource, @tag.Sanity, @tag.JS"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/12708509894>
> Commit: 91840c0
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=12708509894&attempt=1"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.Datasource, @tag.Sanity, @tag.JS`
> Spec:
> <hr>Fri, 10 Jan 2025 12:29:18 UTC
<!-- end of auto-generated comment: Cypress test results  -->


## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [x] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

- **New Features**
- Added automated tests for validating the "Show Bindings" menu in split
pane mode.
	- Introduced new locators for list toggle and bindings menu.

- **Tests**
- Created test cases for checking "Show Bindings" functionality for
JavaScript Objects and API queries.

- **Chores**
- Updated test configurations to focus on specific test cases and
modified locator references in support files.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nerbos nerbos

@hetunandu hetunandu

Labels
Bug Something isn't working IDE Navigation Issues/feature requests related to IDE navigation, and context switching IDE Pod Issues that new developers face while exploring the IDE IDE Product Issues related to the IDE Product Medium Issues that frustrate users due to poor UX Needs Triaging Needs attention from maintainers to triage Production QA Needs QA attention Regressed Scenarios that were working before but have now regressed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Show bindings hiding behind scroll appsmithorg/appsmith
4 participants
@nerbos @hetunandu @shadabbuchh @appsmith-bot