Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Task] Git pkg - Git module integraiton #38505

Closed
brayn003 opened this issue Jan 6, 2025 · 0 comments · Fixed by #39255 or #39342
Closed

[Task] Git pkg - Git module integraiton #38505

brayn003 opened this issue Jan 6, 2025 · 0 comments · Fixed by #39255 or #39342
Assignees
@brayn003
Labels
Git Product Issues related to version control product Packages & Git Pod All issues belonging to Packages and Git Task A simple Todo

Comments

@brayn003
Copy link
Contributor

brayn003 commented Jan 6, 2025

No description provided.

@brayn003 brayn003 added the Packages & Git Pod All issues belonging to Packages and Git label Jan 6, 2025
@Nikhil-Nandagopal Nikhil-Nandagopal added the Task A simple Todo label Jan 6, 2025
@github-actions github-actions bot removed the Packages & Git Pod All issues belonging to Packages and Git label Jan 6, 2025
@brayn003 brayn003 self-assigned this Jan 6, 2025
@brayn003 brayn003 added the Git Product Issues related to version control product label Jan 6, 2025
@github-actions github-actions bot added the Packages & Git Pod All issues belonging to Packages and Git label Jan 6, 2025
@brayn003 brayn003 mentioned this issue Feb 16, 2025
Merged
2 tasks
brayn003 added a commit that referenced this issue Feb 18, 2025
@brayn003
chore: git pkg - mod fixes (#39255)
242840d 
## Description
- Introducing artifact aware permissions
- Better error handling for sagas
- New API contracts for local profile

Fixes #38505

## Automation

/ok-to-test tags="@tag.Git"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/13375089313>
> Commit: 13aa020
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=13375089313&attempt=1"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.Git`
> Spec:
> <hr>Mon, 17 Feb 2025 17:44:17 UTC
<!-- end of auto-generated comment: Cypress test results  -->


## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [ ] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

- **New Features**
- Enhanced Git integration with adaptive connection messages and success
modals that now reflect the type of artifact being handled.
- Added support for storing additional Git metadata to improve artifact
management.

- **Refactor**
- Streamlined error handling across Git operations to ensure more
reliable feedback.
- Updated permission structures and context management to deliver a more
robust and flexible Git experience.

- **Chores**
- Consolidated module organization and improved type consistency for
better maintainability.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
@brayn003 brayn003 mentioned this issue Feb 18, 2025
Merged
2 tasks
brayn003 added a commit that referenced this issue Feb 19, 2025
@brayn003
chore: git pkg - package integration with git (#39342)
8d4f616 
## Description
- integrating packages with git

Fixes #38505

## Automation

/ok-to-test tags="@tag.Git"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/13409662643>
> Commit: 820025a
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=13409662643&attempt=1"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.Git`
> Spec:
> <hr>Wed, 19 Feb 2025 10:39:11 UTC
<!-- end of auto-generated comment: Cypress test results  -->


## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [ ] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

- **New Features**
- Enhanced the Git import process to better distinguish between complete
and partial imports, triggering appropriate UI prompts and navigation.
  - Introduced a new action for handling successful Git imports.

- **Refactor**
- Streamlined the underlying logic for Git import handling to deliver
clearer user feedback and a more efficient experience.

- **Chores**
- Updated type definitions and action payloads for improved type safety
and maintainability.
- Added `.lens` to the `.gitignore` file to exclude it from version
control.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@brayn003 brayn003

Labels
Git Product Issues related to version control product Packages & Git Pod All issues belonging to Packages and Git Task A simple Todo
Projects
None yet
Milestone
No milestone
2 participants
@Nikhil-Nandagopal @brayn003