Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: Remove duplicate schema API calls on expanding entity even after Refresh #36348

Open
1 task done
NandanAnantharamu opened this issue Sep 16, 2024 · 0 comments
Open
1 task done

[Bug]: Remove duplicate schema API calls on expanding entity even after Refresh #36348

NandanAnantharamu opened this issue Sep 16, 2024 · 0 comments
Assignees
@Nikhil-Nandagopal @pranavkanade @rohan-arthur @carinanfonseca
Labels
Bug Something isn't working Core Query Execution Issues related to the execution of all queries Data Platform Pod Issues related to the underlying data platform Integrations Product Issues related to a specific integration Needs Triaging Needs attention from maintainers to triage

Comments

@NandanAnantharamu
Copy link
Collaborator

Is there an existing issue for this?

  • I have searched the existing issues

Description

The API (to fetch the Datasource structure)is called twice on expanding the entity even after refresh.

Original bug : #18403

The issue was caught from automation script: cypress/e2e/Regression/ClientSide/BugTests/DatasourceSchema_spec.ts

Cypress dashboard: https://internal.appsmith.com/app/cypress-dashboard/run-details-65890b3c81d7400d08fa9ee5?branch=master&workflowId=10775575341&attempt=1&selectiontype=test&testsstatus=failed&specsstatus=fail

Steps To Reproduce

1.Createa a DS.
2.add quesry for the DS created
3.Verify if the schema is fetched wit one call.
4.Refresh the page and check if the schema is fetched with one call.

Expected:
Post refresh it was expected to fetch the schema with 1 call.

Actual:
Its taking 2 call to fetch the schema

The issue was caught from automation script: cypress/e2e/Regression/ClientSide/BugTests/DatasourceSchema_spec.ts

Cypress dashboard: https://internal.appsmith.com/app/cypress-dashboard/run-details-65890b3c81d7400d08fa9ee5?branch=master&workflowId=10775575341&attempt=1&selectiontype=test&testsstatus=failed&specsstatus=fail

Public Sample App

No response

Environment

Release

Severity

Medium (Frustrating UX)

Issue video log

No response

Version

v1.40
@NandanAnantharamu NandanAnantharamu added Bug Something isn't working Needs Triaging Needs attention from maintainers to triage labels Sep 16, 2024
@Nikhil-Nandagopal Nikhil-Nandagopal added Community Reported issues reported by community members Medium Issues that frustrate users due to poor UX Release labels Sep 16, 2024
@NandanAnantharamu NandanAnantharamu added Query & JS Pod Issues related to the query & JS Pod Data Platform Pod Issues related to the underlying data platform and removed Release Community Reported issues reported by community members Medium Issues that frustrate users due to poor UX labels Sep 16, 2024
@github-project-automation github-project-automation bot moved this to Needs Triaging in Data Platform Pod Sep 16, 2024
@NandanAnantharamu NandanAnantharamu added the Core Query Execution Issues related to the execution of all queries label Sep 16, 2024
@github-actions github-actions bot added Integrations Product Issues related to a specific integration and removed Query & JS Pod Issues related to the query & JS Pod labels Sep 16, 2024
@NandanAnantharamu NandanAnantharamu mentioned this issue Sep 16, 2024
Merged
NandanAnantharamu added a commit that referenced this issue Sep 16, 2024
@NandanAnantharamu
test: fix DataSourceScheme (#36339)
5dfbe8c 
test:
Fixing DataSourceScheme test

EE PR: appsmithorg/appsmith-ee#5155

Improved reliability of data source schema tests by ensuring correct UI
interactions and logical flow.
Enhanced verification process by checking for the absence of loading
spinners before data verification.

**Bugs Raised as part of fixing the spec:**

#36349
Test Skipped: #36348

/ok-to-test tags="@tag.All"



<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/10885399399>
> Commit: 12ca3b6
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=10885399399&attempt=1"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.All`
> Spec:
> <hr>Mon, 16 Sep 2024 15:08:37 UTC
<!-- end of auto-generated comment: Cypress test results  -->


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

## Summary by CodeRabbit

- **Bug Fixes**
- Skipped a test case for schema fetching due to a known bug, improving
test reliability.
  
- **New Features**
- Enhanced search functionality within the datasource structure,
ensuring previous inputs do not interfere with new searches.
- Improved interaction with the schema tab in the user interface for
better testing.

- **Documentation**
- Updated the path for limited tests to focus on the "Datasource Schema"
functionality.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->

---------

Co-authored-by: “NandanAnantharamu” <“nandan@thinkify.io”>
Shivam-z pushed a commit to Shivam-z/appsmith that referenced this issue Sep 26, 2024
@NandanAnantharamu @Shivam-z
test: fix DataSourceScheme (appsmithorg#36339)
52ab83c 
test:
Fixing DataSourceScheme test

EE PR: https://github.com/appsmithorg/appsmith-ee/pull/5155

Improved reliability of data source schema tests by ensuring correct UI
interactions and logical flow.
Enhanced verification process by checking for the absence of loading
spinners before data verification.

**Bugs Raised as part of fixing the spec:**

appsmithorg#36349
Test Skipped: appsmithorg#36348

/ok-to-test tags="@tag.All"



<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/10885399399>
> Commit: 12ca3b6
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=10885399399&attempt=1"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.All`
> Spec:
> <hr>Mon, 16 Sep 2024 15:08:37 UTC
<!-- end of auto-generated comment: Cypress test results  -->


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

## Summary by CodeRabbit

- **Bug Fixes**
- Skipped a test case for schema fetching due to a known bug, improving
test reliability.
  
- **New Features**
- Enhanced search functionality within the datasource structure,
ensuring previous inputs do not interfere with new searches.
- Improved interaction with the schema tab in the user interface for
better testing.

- **Documentation**
- Updated the path for limited tests to focus on the "Datasource Schema"
functionality.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->

---------

Co-authored-by: “NandanAnantharamu” <“nandan@thinkify.io”>
@coderabbitai coderabbitai bot mentioned this issue Oct 3, 2024
Closed
@coderabbitai coderabbitai bot mentioned this issue Nov 1, 2024
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Nikhil-Nandagopal Nikhil-Nandagopal

@pranavkanade pranavkanade

@rohan-arthur rohan-arthur

@carinanfonseca carinanfonseca

Labels
Bug Something isn't working Core Query Execution Issues related to the execution of all queries Data Platform Pod Issues related to the underlying data platform Integrations Product Issues related to a specific integration Needs Triaging Needs attention from maintainers to triage
Projects
Data Platform Pod
Status: Needs Triaging
Milestone
No milestone
Development

No branches or pull requests
5 participants
@Nikhil-Nandagopal @pranavkanade @NandanAnantharamu @rohan-arthur @carinanfonseca