Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: When the user updates their name in the profile, the policies for that user's resource object disappears. #36063

Closed
1 task done
nsarupr opened this issue Sep 3, 2024 · 0 comments · Fixed by #36206
Closed
1 task done

[Bug]: When the user updates their name in the profile, the policies for that user's resource object disappears. #36063

nsarupr opened this issue Sep 3, 2024 · 0 comments · Fixed by #36206
Assignees
@riteshkew @nsarupr @abhvsn
Labels
Bug Something isn't working High This issue blocks a user from building or impacts a lot of users Platform Administration Pod Issues related to platform administration & management Production QA Pod Issues under the QA Pod QA Needs QA attention RBAC Product Issues, requests and enhancements around RBAC. Workflows Pod Issues that the workflows team owns Workflows Product Issues related to the workflows product

Comments

@nsarupr
Copy link
Contributor

nsarupr commented Sep 3, 2024

Is there an existing issue for this?

  • I have searched the existing issues

Description

When a user updates their name from profile, the instance administrator stops seeing that user in the User Listing page.

Steps To Reproduce

  1. Login as a User.
  2. Update your name from profile.
  3. Login as Admin User.
  4. Check users listing page.

Observation: The user who updated their name is missing from the User's listing page.

Public Sample App

No response

Environment

Production

Severity

High (Blocker to building or releasing)

Issue video log

No response

Version

Self Hosted
@nsarupr nsarupr added Bug Something isn't working Needs Triaging Needs attention from maintainers to triage RBAC Product Issues, requests and enhancements around RBAC. labels Sep 3, 2024
@Nikhil-Nandagopal Nikhil-Nandagopal added High This issue blocks a user from building or impacts a lot of users Production labels Sep 3, 2024
@github-actions github-actions bot added the Platform Administration Pod Issues related to platform administration & management label Sep 3, 2024
@nsarupr nsarupr removed the Needs Triaging Needs attention from maintainers to triage label Sep 3, 2024
@abhvsn abhvsn mentioned this issue Sep 7, 2024
Merged
2 tasks
abhvsn added a commit that referenced this issue Sep 9, 2024
@abhvsn
fix: NPE while creating a policies copy (#36172)
1b16be8 
## Description
PR to handle the empty collection and null values for policies. We
expect web should never end up in this state but we have received enough
evidences that because of broken functionality in GAC we may end up in
this scenario. One such example is
#36063

/test all

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!CAUTION]
> 🔴 🔴 🔴 Some tests have failed.
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/10767073729>
> Commit: e225d54
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=10767073729&attempt=2&selectiontype=test&testsstatus=failed&specsstatus=fail"
target="_blank">Cypress dashboard</a>.
> Tags: @tag.All
> Spec: 
> The following are new failures, please fix them before merging the PR:
<ol>
>
<li>cypress/e2e/Regression/ClientSide/Debugger/Widget_property_navigation_spec.ts
>
<li>cypress/e2e/Regression/ClientSide/OneClickBinding/PropertyControl_spec.ts</ol>
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/identified-flaky-tests-65890b3c81d7400d08fa9ee3?branch=master"
target="_blank">List of identified flaky tests</a>.
> <hr>Mon, 09 Sep 2024 07:01:41 UTC
<!-- end of auto-generated comment: Cypress test results  -->


## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [x] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit


- **Bug Fixes**
- Improved handling of user permissions to prevent potential errors
related to null values in policies.
- Enhanced robustness in policy management methods to avoid null-related
errors when retrieving existing policies.
- **Tests**
- Added unit tests for user permissions handling and policy management
to ensure robust behavior under various conditions.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
@nsarupr nsarupr mentioned this issue Sep 9, 2024
Merged
2 tasks
nsarupr added a commit that referenced this issue Sep 10, 2024
@nsarupr
fix: updateWithoutPermission updates user instead of saving it (#36206)
316f914 
## Description
> UserService$updateWithoutPermission will now update the user instead
of saving it.

Fixes #36063

## Automation

/ok-to-test tags="@tag.Sanity"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/10786655302>
> Commit: 0eb7f18
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=10786655302&attempt=1"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.Sanity`
> Spec:
> <hr>Tue, 10 Sep 2024 06:20:46 UTC
<!-- end of auto-generated comment: Cypress test results  -->


## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [x] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit


## Summary by CodeRabbit

- **New Features**
	- Enhanced user update functionality for more efficient processing.
- Added a mechanism to ensure user policies remain unchanged during
updates.

- **Bug Fixes**
- Implemented tests to verify that user name updates do not affect
associated policies.

- **Tests**
- Introduced new test methods to validate user update scenarios within
the correct security context.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->

---------

Co-authored-by: Nilesh Sarupriya <20905988+nsarupr@users.noreply.github.com>
@appsmith-bot appsmith-bot added the QA Needs QA attention label Sep 10, 2024
@github-actions github-actions bot added the QA Pod Issues under the QA Pod label Sep 10, 2024
@nsarupr nsarupr added Workflows Pod Issues that the workflows team owns Workflows Product Issues related to the workflows product labels Sep 11, 2024
Shivam-z pushed a commit to Shivam-z/appsmith that referenced this issue Sep 26, 2024
@abhvsn @Shivam-z
fix: NPE while creating a policies copy (appsmithorg#36172)
cdd5b25 
## Description
PR to handle the empty collection and null values for policies. We
expect web should never end up in this state but we have received enough
evidences that because of broken functionality in GAC we may end up in
this scenario. One such example is
appsmithorg#36063

/test all

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!CAUTION]
> 🔴 🔴 🔴 Some tests have failed.
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/10767073729>
> Commit: e225d54
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=10767073729&attempt=2&selectiontype=test&testsstatus=failed&specsstatus=fail"
target="_blank">Cypress dashboard</a>.
> Tags: @tag.All
> Spec: 
> The following are new failures, please fix them before merging the PR:
<ol>
>
<li>cypress/e2e/Regression/ClientSide/Debugger/Widget_property_navigation_spec.ts
>
<li>cypress/e2e/Regression/ClientSide/OneClickBinding/PropertyControl_spec.ts</ol>
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/identified-flaky-tests-65890b3c81d7400d08fa9ee3?branch=master"
target="_blank">List of identified flaky tests</a>.
> <hr>Mon, 09 Sep 2024 07:01:41 UTC
<!-- end of auto-generated comment: Cypress test results  -->


## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [x] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit


- **Bug Fixes**
- Improved handling of user permissions to prevent potential errors
related to null values in policies.
- Enhanced robustness in policy management methods to avoid null-related
errors when retrieving existing policies.
- **Tests**
- Added unit tests for user permissions handling and policy management
to ensure robust behavior under various conditions.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
Shivam-z pushed a commit to Shivam-z/appsmith that referenced this issue Sep 26, 2024
@nsarupr @Shivam-z
fix: updateWithoutPermission updates user instead of saving it (appsm…
3c379d1 
…ithorg#36206)

## Description
> UserService$updateWithoutPermission will now update the user instead
of saving it.

Fixes appsmithorg#36063

## Automation

/ok-to-test tags="@tag.Sanity"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/10786655302>
> Commit: 0eb7f18
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=10786655302&attempt=1"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.Sanity`
> Spec:
> <hr>Tue, 10 Sep 2024 06:20:46 UTC
<!-- end of auto-generated comment: Cypress test results  -->


## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [x] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit


## Summary by CodeRabbit

- **New Features**
	- Enhanced user update functionality for more efficient processing.
- Added a mechanism to ensure user policies remain unchanged during
updates.

- **Bug Fixes**
- Implemented tests to verify that user name updates do not affect
associated policies.

- **Tests**
- Introduced new test methods to validate user update scenarios within
the correct security context.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->

---------

Co-authored-by: Nilesh Sarupriya <20905988+nsarupr@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@riteshkew riteshkew

@nsarupr nsarupr

@abhvsn abhvsn

Labels
Bug Something isn't working High This issue blocks a user from building or impacts a lot of users Platform Administration Pod Issues related to platform administration & management Production QA Pod Issues under the QA Pod QA Needs QA attention RBAC Product Issues, requests and enhancements around RBAC. Workflows Pod Issues that the workflows team owns Workflows Product Issues related to the workflows product
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: updateWithoutPermission updates user instead of saving it appsmithorg/appsmith
5 participants
@Nikhil-Nandagopal @riteshkew @nsarupr @abhvsn @appsmith-bot