-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Task]: Update REST API & GraphQL save datasource design #35503
Labels
IDE Navigation
Issues/feature requests related to IDE navigation, and context switching
IDE Pod
Issues that new developers face while exploring the IDE
IDE Product
Issues related to the IDE Product
Task
A simple Todo
Milestone
Comments
6 tasks
github-actions
bot
added
the
potential-duplicate
This label marks issues that are potential duplicates of already open issues
label
Aug 7, 2024
albinAppsmith
added
IDE Navigation
Issues/feature requests related to IDE navigation, and context switching
and removed
potential-duplicate
This label marks issues that are potential duplicates of already open issues
labels
Aug 7, 2024
albinAppsmith
added
IDE Navigation
Issues/feature requests related to IDE navigation, and context switching
and removed
IDE Navigation
Issues/feature requests related to IDE navigation, and context switching
labels
Aug 8, 2024
github-actions
bot
added
IDE Product
Issues related to the IDE Product
IDE Pod
Issues that new developers face while exploring the IDE
labels
Aug 8, 2024
albinAppsmith
changed the title
[Task]: Add Zone & Section to Rest API plugin form
[Task]: Update REST API & GraphQL save datasource design
Sep 10, 2024
2 tasks
albinAppsmith
added a commit
that referenced
this issue
Sep 11, 2024
Loading
Loading status checks…
## Description This PR updates the save datasource text to "Save" and edit datasource text to "Edit". Also, updated the save datasource icon to better represent datasource. Fixes #35503 ## Automation /ok-to-test tags="@tag.All" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/10807660093> > Commit: fda9c74 > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=10807660093&attempt=2" target="_blank">Cypress dashboard</a>. > Tags: `@tag.All` > Spec: > <hr>Wed, 11 Sep 2024 09:43:42 UTC <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [x] No <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **New Features** - Simplified user interface messages for editing and saving data sources to "Edit" and "Save." - Updated the icon for the save button to better represent the action when saving a datasource. - Introduced a new locator for the save datasource button to enhance testing capabilities. - **Bug Fixes** - Improved adherence to coding standards by modifying ESLint rules related to function props. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
Shivam-z
pushed a commit
to Shivam-z/appsmith
that referenced
this issue
Sep 26, 2024
…org#36222) ## Description This PR updates the save datasource text to "Save" and edit datasource text to "Edit". Also, updated the save datasource icon to better represent datasource. Fixes appsmithorg#35503 ## Automation /ok-to-test tags="@tag.All" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/10807660093> > Commit: fda9c74 > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=10807660093&attempt=2" target="_blank">Cypress dashboard</a>. > Tags: `@tag.All` > Spec: > <hr>Wed, 11 Sep 2024 09:43:42 UTC <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [x] No <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **New Features** - Simplified user interface messages for editing and saving data sources to "Edit" and "Save." - Updated the icon for the save button to better represent the action when saving a datasource. - Introduced a new locator for the save datasource button to enhance testing capabilities. - **Bug Fixes** - Improved adherence to coding standards by modifying ESLint rules related to function props. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
IDE Navigation
Issues/feature requests related to IDE navigation, and context switching
IDE Pod
Issues that new developers face while exploring the IDE
IDE Product
Issues related to the IDE Product
Task
A simple Todo
Design: https://zpl.io/6JNzDnK
The text was updated successfully, but these errors were encountered: