Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: Function names in a JS object for workflows are not getting renamed #34470

Closed
1 task done
ayushpahwa opened this issue Jun 25, 2024 · 0 comments · Fixed by #34512
Closed
1 task done

[Bug]: Function names in a JS object for workflows are not getting renamed #34470

ayushpahwa opened this issue Jun 25, 2024 · 0 comments · Fixed by #34512
Assignees
@ayushpahwa
Labels
Bug Something isn't working High This issue blocks a user from building or impacts a lot of users Low An issue that is neither critical nor breaks a user flow Needs Triaging Needs attention from maintainers to triage Production QA Pod Issues under the QA Pod QA Needs QA attention Workflows Pod Issues that the workflows team owns Workflows Product Issues related to the workflows product
Milestone
WF-24Jun-5Jul

Comments

@ayushpahwa
Copy link
Contributor

Is there an existing issue for this?

  • I have searched the existing issues

Description

Function names in workflow js objects are not getting renamed

Steps To Reproduce

  1. Create a new workflow and then create a new function in the main JS object.
  2. Rename the function
  3. See that on the top right dropdown the function name is not updated.

Public Sample App

No response

Environment

Production

Severity

Low (Cosmetic UI issues)

Issue video log

No response

Version

Self hosted 1.28
@ayushpahwa ayushpahwa added Bug Something isn't working High This issue blocks a user from building or impacts a lot of users Needs Triaging Needs attention from maintainers to triage Workflows Pod Issues that the workflows team owns Workflows Product Issues related to the workflows product labels Jun 25, 2024
@ayushpahwa ayushpahwa added this to the WF-24Jun-5Jul milestone Jun 25, 2024
@ayushpahwa ayushpahwa self-assigned this Jun 25, 2024
@Nikhil-Nandagopal Nikhil-Nandagopal added Low An issue that is neither critical nor breaks a user flow Production labels Jun 25, 2024
@ayushpahwa ayushpahwa mentioned this issue Jun 26, 2024
Merged
2 tasks
ayushpahwa added a commit that referenced this issue Jun 28, 2024
@ayushpahwa
fix: workflow js func rename code split (#34512)
e662e7e 
## Description
This is a code split PR for [EE
change](appsmithorg/appsmith-ee#4536) which
fixes rename of functions inside of a js object.


Fixes [#34470](#34470)

## Automation

/test sanity

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/9690260557>
> Commit: 6da583f
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=9690260557&attempt=1"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.Sanity`

<!-- end of auto-generated comment: Cypress test results  -->




## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [x] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

- **New Features**
- Added an optional `workflowId` field to enhance the functionality of
JavaScript actions and workflows.

- **Tests**
  - Updated tests to include the new `workflowId` field.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
@appsmith-bot appsmith-bot added the QA Needs QA attention label Jun 28, 2024
@github-actions github-actions bot added the QA Pod Issues under the QA Pod label Jun 28, 2024
Shivam-z pushed a commit to Shivam-z/appsmith that referenced this issue Jul 10, 2024
@ayushpahwa @Shivam-z
fix: workflow js func rename code split (appsmithorg#34512)
71e9af6 
## Description
This is a code split PR for [EE
change](https://github.com/appsmithorg/appsmith-ee/pull/4536) which
fixes rename of functions inside of a js object.


Fixes [appsmithorg#34470](appsmithorg#34470)

## Automation

/test sanity

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/9690260557>
> Commit: 6da583f
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=9690260557&attempt=1"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.Sanity`

<!-- end of auto-generated comment: Cypress test results  -->




## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [x] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

- **New Features**
- Added an optional `workflowId` field to enhance the functionality of
JavaScript actions and workflows.

- **Tests**
  - Updated tests to include the new `workflowId` field.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ayushpahwa ayushpahwa

Labels
Bug Something isn't working High This issue blocks a user from building or impacts a lot of users Low An issue that is neither critical nor breaks a user flow Needs Triaging Needs attention from maintainers to triage Production QA Pod Issues under the QA Pod QA Needs QA attention Workflows Pod Issues that the workflows team owns Workflows Product Issues related to the workflows product
Projects
None yet
Milestone
WF-24Jun-5Jul
Development

Successfully merging a pull request may close this issue.

fix: workflow js func rename code split appsmithorg/appsmith
3 participants
@Nikhil-Nandagopal @ayushpahwa @appsmith-bot