Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: Widget name closure delay for Modal Widget #33381

Closed
riodeuno opened this issue May 13, 2024 · 0 comments · Fixed by #33705
Closed

[Bug]: Widget name closure delay for Modal Widget #33381

riodeuno opened this issue May 13, 2024 · 0 comments · Fixed by #33705
Assignees
@riodeuno
Labels
Anvil Pod Issue related to Anvil project Anvil team issues related to the new layout system anvil High This issue blocks a user from building or impacts a lot of users Task A simple Todo
Milestone
R1 - Polish

Comments

@riodeuno
Copy link
Contributor

riodeuno commented May 13, 2024 •
edited
Loading

There is a delay in closing the widget name component after the modal widget closes. This applies to it's child widgets too @riodeuno
@riodeuno riodeuno mentioned this issue May 13, 2024
Closed
13 tasks
@Nikhil-Nandagopal Nikhil-Nandagopal added the Task A simple Todo label May 13, 2024
@riodeuno riodeuno changed the title There is a delay in closing the widget name component after the modal widget closes. This applies to it's child widgets too @riodeuno [Bug]: Widget name closure delay for Modal Widget May 13, 2024
@riodeuno riodeuno self-assigned this May 13, 2024
@riodeuno riodeuno added High This issue blocks a user from building or impacts a lot of users Anvil Pod Issue related to Anvil project Anvil team issues related to the new layout system anvil labels May 13, 2024
@somangshu somangshu added this to the R1 - Polish milestone May 14, 2024
@riodeuno riodeuno mentioned this issue May 23, 2024
Merged
2 tasks
riodeuno added a commit that referenced this issue May 24, 2024
@riodeuno
fix: Anvil: Fix the delay in closure of modal widget name component o…
75bd429 
…n modal close (#33705)

## Description
Closing the modal widget name component was delayed due to the fact that
the DOM node that the widget name component used as a reference, was
still available even after the modal wasn't visible on the Canvas.
This was due to the floating-ui taking time to remove the DOM node.

As a fix, I've made react remove the DOM node when the state for the
modal visibility is set to `false`.

Now, the widget name component closes as soon as it discovers that the
reference is hidden.

Additional fix: Changed the detached widget hook functions to be
agnostic of the term "modal".

Fixes #33381  

## Automation

/ok-to-test tags="@tag.Anvil"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/9219824326>
> Commit: 3f3f626
> Cypress dashboard url: <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=9219824326&attempt=1"
target="_blank">Click here!</a>

<!-- end of auto-generated comment: Cypress test results  -->






## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [x] No
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@riodeuno riodeuno

Labels
Anvil Pod Issue related to Anvil project Anvil team issues related to the new layout system anvil High This issue blocks a user from building or impacts a lot of users Task A simple Todo
Projects
None yet
Milestone
R1 - Polish
3 participants
@riodeuno @Nikhil-Nandagopal @somangshu