Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: Toolbar button widget issues on Anvil DP #32109

Closed
1 task done
ramsaptami opened this issue Mar 27, 2024 · 1 comment
Closed
1 task done

[Bug]: Toolbar button widget issues on Anvil DP #32109

ramsaptami opened this issue Mar 27, 2024 · 1 comment
Assignees
@KelvinOm
Labels
Anvil Pod Issue related to Anvil project Bug Something isn't working High This issue blocks a user from building or impacts a lot of users WDS team
Milestone
R1 - Polish

Comments

@ramsaptami
Copy link
Contributor

ramsaptami commented Mar 27, 2024 •
edited
Loading

Is there an existing issue for this?

  • I have searched the existing issues

Description

  1. Icons are ignored when displayed inside “kebab” menu (must be there)
  2. Separators are displayed incorrectly when inside the “kebab” menu (must be separators, not menu items)

original post

Steps To Reproduce

  1. drop a toolbar widget on the new Anvil instance
  2. Add 2-3 more buttons to the list so they appear under the "kebab" menu
  3. Assign icons to the options and observe the behaviour

image

Public Sample App

No response

Environment

Deploy Preview

Severity

High

Issue video log

No response

Version

cloud
@ramsaptami ramsaptami added Bug Something isn't working Needs Triaging Needs attention from maintainers to triage WDS team WDS - toolbar widget labels Mar 27, 2024
@github-actions github-actions bot added the Anvil Pod Issue related to Anvil project label Mar 27, 2024
@Nikhil-Nandagopal Nikhil-Nandagopal added Deploy Preview Issues found in Deploy Preview High This issue blocks a user from building or impacts a lot of users labels Mar 27, 2024
@KelvinOm KelvinOm removed Needs Triaging Needs attention from maintainers to triage Deploy Preview Issues found in Deploy Preview WDS - toolbar widget labels Mar 27, 2024
@KelvinOm KelvinOm self-assigned this May 1, 2024
@KelvinOm
Copy link
Collaborator

KelvinOm commented May 6, 2024

Hey team! Please add your planning poker estimate with Zenhub @jsartisan @marks0351 @riodeuno

@somangshu somangshu added this to the Widget polish - R1 milestone May 6, 2024
@somangshu somangshu modified the milestones: Widget polish - R1, R1 - Polish May 14, 2024
@KelvinOm KelvinOm mentioned this issue May 23, 2024
Merged
2 tasks
KelvinOm added a commit that referenced this issue May 24, 2024
@KelvinOm @jsartisan
fix: refactor wds menu and related components, widgets (#33703)
55ae859 
## Description
1. WDS menu component has been completely refactored. WDS headless
component has been removed, we use `react-aria-components` instead. The
menu component now has the ability to use submenus and icons for items.
2. Rename components `ActionGroup` to `ToolbarButtons and `ButtonGroup`
to `InlineButtons`
3. Make API of the `ToolbarButtons`, `Menu`, `InlineButtons`, `Select`
consistent.
4. Cosmetic refactoring of `ToolbarButtons` and `InlineButtons` and
related widgets.

Fixes:
#32299
#32109

## Automation

/ok-to-test tags="@tag.Anvil"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/9210315418>
> Commit: b11c002
> Cypress dashboard url: <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=9210315418&attempt=1"
target="_blank">Click here!</a>

<!-- end of auto-generated comment: Cypress test results  -->




## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [x] No

---------

Co-authored-by: Pawan Kumar <pawan@appsmith.com>
@ramsaptami ramsaptami mentioned this issue May 30, 2024
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@KelvinOm KelvinOm

Labels
Anvil Pod Issue related to Anvil project Bug Something isn't working High This issue blocks a user from building or impacts a lot of users WDS team
Projects
None yet
Milestone
R1 - Polish
Development

No branches or pull requests
4 participants
@Nikhil-Nandagopal @somangshu @KelvinOm @ramsaptami