[Bug]: Select widget should display label instead of value while editing a table cell #26188

keyurparalkar · 2023-08-09T03:37:43Z

Is there an existing issue for this?

I have searched the existing issues

Description

Whenever a select column type cell is editable and when user actually selects the value from drop down for the cell, then select option's value property is updated in cell's data. It is expected that select option's label property should get updated in cell data.

Steps To Reproduce

Drag and drop a table widget and bind a query to this widget.
Change one of it's column to select type and add select options to it.
Make this column editable
Now try to edit this cell
Observe that selecting an option from the select dropdown sets the cell's data to the value property of select option instead of label

Public Sample App

No response

Environment

Production

Issue video log

No response

Version

Cloud

Tasks

Give feedback

[Task]: Add missing options property for select column type in table widget #27061

Task
[Task]: Update table widget's documentation for displayAs property #27093

Documentation Documentation Pod Needs More Info Table Widget Task Widgets & Accelerators Pod Widgets Product
Options

Front conversations

The text was updated successfully, but these errors were encountered:

dilippitchika · 2023-08-10T06:09:25Z

Whenever a column is set to select, by default we show labels and not values.
For existing tables, since we have created this problem we ensure we don't break their apps. We will give an option called "Display As" as suggested in the original issue and for new select columns, it will be Label and for existing columns, it will be Value.
We make it clear that the computed value here refers to the default value/display value.
We make the select widget changes we did for options in the table and json form as well, create a new issue for this.
When the user has turned on server side filtering, we will ask the user to provide additional details for labels to be shown for cases where we cannot find them in options.
Depending on the "display as" property, we alter the search, sort and filter behavior accordingly.

@keyurparalkar @sbalaji1192

keyurparalkar · 2023-09-07T09:12:12Z

@dilippitchika I have raised a new feature request for point 4 mentioned above.

somangshu · 2024-02-02T09:02:27Z

@rishabhrathod01 you think this is realted to #30074

MAL0780 · 2024-02-07T11:06:34Z

Please, prioritize.
Wanted to use select in a table visualizing "labels" and using "values".
Thank you!

Scrafi4 · 2024-02-16T05:30:49Z

Hello!

I've created a public app to demonstrate a bug observed in the "gender" column. You can access the app here:
https://app.appsmith.com/app/select-in-column-bug/page1-65cee8067b1fda250a586c71?embed=true

The issue occurs when I attempt to edit a cell within this column and select a different option. Instead of displaying the labels "female" or "male", the cell shows the numerical values 1 or 2, respectively. Here's the data structure I'm using for the dropdown options:

[
  {
    "label": "female",
    "value": 1
  },
  {
    "label": "male",
    "value": 2
  }
]

I'm building an app where managers update client cities from a set list. This bug hurts a lot and makes updates with foreign key relations basically impossible.

AndreeaIAM · 2024-03-05T15:08:51Z

Please, prioritize.
I have the same problem as [Scrafi4] .
Thank you!

neilhanhan · 2024-04-02T02:51:51Z

I have the same problem.
Please, prioritize.
Thanks!

rlnorthcutt · 2024-04-03T15:53:15Z

We had another customer hit this today.

rlnorthcutt · 2024-04-03T15:54:34Z

I think we have a duplicate issue here: #21993

rlnorthcutt · 2024-04-03T21:35:47Z

For context, see this screen shot. If I want to edit a field with a select, then I see the value (an id) as the default, but I can see the label when I'm selecting... but then once it is selected, I see the value again. This takes a very simple and powerful feature of the table, and makes it unusable.

In theory, I could parse the DB data, swap out the ids for the labels, and then try to swap them back again before saving to the DB... but this is incredibly messy. For now, it is best to use a JSON form for the editing, which severely limits the edit capabilities of the table row.

bastien-naturavelo · 2024-06-21T10:11:09Z

Looking forward for a fix :)

awalters141 · 2024-07-02T15:39:23Z

I would also like this to be worked on. I need my users to be able to select from just the label without seeing the value. Thank you.

…e widget (appsmithorg#34743) ## Description **Issue** In the table widget, the select column currently displays the value from the dropdown when a user makes a selection, rather than the label. This behaviour is inconsistent with the standalone select widget, which correctly renders the label upon selection. **Fix** This PR addresses the inconsistency by modifying the table widget's select column to display the label of the selected item, ensuring alignment with the behaviour of the standalone select widget. Fixes appsmithorg#26188 ## Automation /ok-to-test tags="@tag.Table, @tag.Binding, @tag.Widget, @tag.Sanity" ### 🔍 Cypress test results  > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/9843945454> > Commit: 330d0d3 > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=9843945454&attempt=1" target="_blank">Cypress dashboard</a>. > Tags: `@tag.Table, @tag.Binding, @tag.Widget, @tag.Sanity` > Spec: > <hr>Mon, 08 Jul 2024 18:21:02 UTC  ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [x] No  ## Summary by CodeRabbit - **Bug Fixes** - Updated the `SelectCell` component to use the `option.label` instead of `option.value` for item selection. - **Tests** - Revised test descriptions and assertions for select options in Table Widget to reflect the new functionality of using labels as values in select cells.

magliok-wwt · 2024-07-17T13:36:52Z

We have hit this same issue.

magliok-wwt · 2024-07-27T02:54:43Z

Is this fixed for anyone else? I don't see that this is fixed/updated to v1.32

The table control still initially shows the value from query (the value of the select options in my case), and even after a new selection, the same thing happens and the table goes back to the value. Label is only ever used/shown once you're editing the value.

## Description **Issue** In the table widget, the select column currently displays the value from the dropdown when a user makes a selection, rather than the label. This behaviour is inconsistent with the standalone select widget, which correctly renders the label upon selection. **Fix** This PR addresses the inconsistency by modifying the table widget's select column to display the label of the selected item, while maintaining the table cell value and ensuring alignment with the behaviour of the standalone select widget. **Tested Cases** Manual Test Cases for Table Select Widget Improvement 1. Default Value Display **Objective:** Ensure that a new table displays the correct default label key from the selectOptions in the cell. **Steps:** - Drop a new table widget. - Add sample data to the table. - Set a column (e.g., gender) to select type. - Verify that the table cell displays the value from the label key of the `selectOptions` by default. 2. Binding Check for Selected Row **Objective:** Ensure that the table binding for the selected row reflects the correct value key from the selectOptions. **Steps:** - Drop a new table widget. - Add sample data to the table. - Set a column (e.g., gender) to select type. - Select a row and verify that `Table1.selectedRow.gender` matches the value key from the `selectOptions`. 3. Updating Table Cell Content **Objective:** Verify that updating the table cell content via the dropdown updates the cell with the correct label key property. **Steps:** - Drop a new table widget. - Add sample data to the table. - Set a column (e.g., gender) to select type. - Change the content of the table cell using the dropdown. - Confirm that the cell content updates accordingly with the value key property. 4. Add New Row Functionality **Objective:** Ensure that adding a new row works as expected with the enhanced functionality. **Steps:** - Drop a new table widget. - Add sample data to the table. - Set a column (e.g., gender) to select type. - Add a new row to the table. - Verify that the new row uses the label key property from the `selectOptions` in the table display. 5. Deployed Mode Verification **Objective:** Verify that the display functionality works correctly in deployed mode. **Steps:** - Drop a new table widget. - Add sample data to the table. - Set a column (e.g., gender) to select type. - Change the displayAs property to both value and label. - Deploy the table. - Verify that the table displays correctly in both value and label modes in the deployed environment. Fixes appsmithorg#26188 ## Automation /ok-to-test tags="@tag.Table, @tag.Binding, @tag.Sanity" ### 🔍 Cypress test results  > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/10080592979> > Commit: 78b268d > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=10080592979&attempt=1" target="_blank">Cypress dashboard</a>. > Tags: `@tag.Table, @tag.Binding, @tag.Sanity` > Spec: > <hr>Wed, 24 Jul 2024 17:17:06 UTC  ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [ ] No  ## Summary by CodeRabbit - **New Features** - Improved display of selected options in table widgets by showing the corresponding label instead of the raw value. - Introduced a feature flag to toggle the table cell label value functionality. - **Bug Fixes** - Enhanced test cases to ensure accurate validation of select options behavior within the table widget.

keyurparalkar added Bug Something isn't working Table Widget High This issue blocks a user from building or impacts a lot of users Needs Triaging Needs attention from maintainers to triage labels Aug 9, 2023

keyurparalkar self-assigned this Aug 9, 2023

github-actions bot added the Widgets Product This label groups issues related to widgets label Aug 9, 2023

keyurparalkar mentioned this issue Sep 1, 2023

fix: Add Display as property to the select column in Table Widget #26855

Closed

20 tasks

somangshu assigned rajatagrawal Sep 22, 2023

somangshu unassigned keyurparalkar Sep 29, 2023

Nikhil-Nandagopal changed the title ~~[Bug]: Value property of select option is set for a cell while editing table data~~ [Bug]: Select widget should display label instead of value while editing a table cell Feb 2, 2024

Nikhil-Nandagopal added the Production label Mar 2, 2024

somangshu removed the Needs Triaging Needs attention from maintainers to triage label Mar 12, 2024

somangshu assigned sbalaji1192 and somangshu and unassigned rajatagrawal Mar 12, 2024

This was referenced Jun 7, 2024

fix: display label instead of value in select column in table widget #26188 #34089

Closed

fix: display label instead of value in select column of table widget #34224

Closed

rahulbarwal added the Widgets & Blocks Pod label Jun 20, 2024

jacquesikot self-assigned this Jul 4, 2024

jacquesikot mentioned this issue Jul 5, 2024

feat: change value to label in onItemSelect inside SelectCell of table widget #34743

Merged

2 tasks

jacquesikot closed this as completed in #34743 Jul 9, 2024

jacquesikot closed this as completed in b7853a9 Jul 9, 2024

appsmith-bot added the QA Needs QA attention label Jul 9, 2024

github-actions bot added the QA Pod Issues under the QA Pod label Jul 9, 2024

jacquesikot reopened this Jul 12, 2024

jacquesikot mentioned this issue Jul 15, 2024

[Bug]: Incorrect Display and Storage of Label Instead of Value for Select Field in Table Widget #34868

Closed

1 task

sapusi mentioned this issue Jul 16, 2024

[Feature]: Add options for labels in select columns in a table widget #21993

Closed

1 task

carinanfonseca added the Help enterprise Requested by Appsmith customers or prospects label Jul 16, 2024

jacquesikot mentioned this issue Jul 23, 2024

feat: display label in table select cell #35124

Merged

2 tasks

jacquesikot closed this as completed in #35124 Jul 25, 2024

jacquesikot closed this as completed in 2cded02 Jul 25, 2024

Nikhil-Nandagopal added the Widgets & Accelerators Pod Issues related to widgets & Accelerators label Aug 6, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Bug]: Select widget should display label instead of value while editing a table cell #26188

[Bug]: Select widget should display label instead of value while editing a table cell #26188

keyurparalkar commented Aug 9, 2023 •

edited by LagunaElectric

Loading

Tasks

dilippitchika commented Aug 10, 2023

keyurparalkar commented Sep 7, 2023

somangshu commented Feb 2, 2024

MAL0780 commented Feb 7, 2024

Scrafi4 commented Feb 16, 2024

AndreeaIAM commented Mar 5, 2024

neilhanhan commented Apr 2, 2024

rlnorthcutt commented Apr 3, 2024

rlnorthcutt commented Apr 3, 2024

rlnorthcutt commented Apr 3, 2024

bastien-naturavelo commented Jun 21, 2024

awalters141 commented Jul 2, 2024

magliok-wwt commented Jul 17, 2024

magliok-wwt commented Jul 27, 2024

[Bug]: Select widget should display label instead of value while editing a table cell #26188

[Bug]: Select widget should display label instead of value while editing a table cell #26188

Comments

keyurparalkar commented Aug 9, 2023 • edited by LagunaElectric Loading

Is there an existing issue for this?

Description

Steps To Reproduce

Public Sample App

Environment

Issue video log

Version

Tasks

dilippitchika commented Aug 10, 2023

keyurparalkar commented Sep 7, 2023

somangshu commented Feb 2, 2024

MAL0780 commented Feb 7, 2024

Scrafi4 commented Feb 16, 2024

AndreeaIAM commented Mar 5, 2024

neilhanhan commented Apr 2, 2024

rlnorthcutt commented Apr 3, 2024

rlnorthcutt commented Apr 3, 2024

rlnorthcutt commented Apr 3, 2024

bastien-naturavelo commented Jun 21, 2024

awalters141 commented Jul 2, 2024

magliok-wwt commented Jul 17, 2024

magliok-wwt commented Jul 27, 2024

keyurparalkar commented Aug 9, 2023 •

edited by LagunaElectric

Loading