Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]-[350]:Random keystrokes trigger autocomplete to show up #15429

Closed
1 task done
ramsaptami opened this issue Jul 25, 2022 · 1 comment · Fixed by #24025
Closed
1 task done

[Bug]-[350]:Random keystrokes trigger autocomplete to show up #15429

ramsaptami opened this issue Jul 25, 2022 · 1 comment · Fixed by #24025
Assignees
Labels
Autocomplete Issues related to the autocomplete Bug Something isn't working Javascript Product Issues related to users writing javascript in appsmith Medium Issues that frustrate users due to poor UX Verified When issue is retested post its fixed

Comments

@ramsaptami
Copy link
Contributor

ramsaptami commented Jul 25, 2022

Is there an existing issue for this?

  • I have searched the existing issues

Description

Need to stop showing autocomplete when:

  1. Code on the editor has already been indented, using keyboard board shortcut causes the autocomplete pop-up to open up wherever the cursor is present
  2. Pasting a code snippet triggers autocomplete to show up
  3. Pressing CTRL + any character shows autocomplete

Steps To Reproduce

  1. Use the following code in the editor and prettify the code from the settings
export default {
	transformAPI: () => {
		const users =  fetchUsers.data.forEach((user) => {
			user.dob = moment(user.dob).format('Do MMM YYYY');
			return user;
		})
		return users
	}
}
  1. Prettify from the drop-down options present on the top right
  2. Now use keyboard shortcut again and observe that the autocomplete pop-up opens up as seen in the video

https://www.loom.com/share/9c22f3e3dd944a8cad11748e2cd1fe31

Public Sample App

No response

Version

Cloud

@ramsaptami ramsaptami added Bug Something isn't working UX Improvement Release Needs Triaging Needs attention from maintainers to triage JS Objects Issues related to JS Objects Medium Issues that frustrate users due to poor UX labels Jul 25, 2022
@github-actions github-actions bot added the Javascript Product Issues related to users writing javascript in appsmith label Jul 25, 2022
@bharath31 bharath31 assigned bharath31 and unassigned rohan-arthur Nov 29, 2022
@bharath31 bharath31 added Autocomplete Issues related to the autocomplete and removed Needs Triaging Needs attention from maintainers to triage labels Feb 7, 2023
@bharath31 bharath31 changed the title [Bug]: Using keyboard shortcut on already indented code causes the autocomplete to open up [Bug]: Random keystrokes trigger autocomplete to show up Feb 16, 2023
@satbir121 satbir121 assigned rimildeyjsr and unassigned bharath31 and satbir121 Mar 31, 2023
@bharath31
Copy link

assuming 5% of autocomplete users face this

Stats

Stat Values
Reach 350
Effort (months) 0.5

@Nikhil-Nandagopal Nikhil-Nandagopal changed the title [Bug]: Random keystrokes trigger autocomplete to show up [Bug]-[350]:Random keystrokes trigger autocomplete to show up Apr 3, 2023
@Nikhil-Nandagopal Nikhil-Nandagopal changed the title [Bug]: Random keystrokes trigger autocomplete to show up [Bug]-[350]:Random keystrokes trigger autocomplete to show up Apr 3, 2023
@bharath31 bharath31 removed UX Improvement Production JS Objects Issues related to JS Objects labels Apr 12, 2023
Aishwarya-U-R pushed a commit that referenced this issue Jun 6, 2023
## Description
PR to fix autocomplete trigger
- Disables autocomplete trigger when ctrl/meta/alt is pressed except for
(ctrl/meta)+space.
- Disable autocomplete inside strings and comments

#### PR fixes following issue(s)
Fixes #15429

#### Type of change
- Bug fix (non-breaking change which fixes an issue)

## Testing
>
#### How Has This Been Tested?
- [x] Manual
- [ ] Jest
- [x] Cypress
>
#### Test Plan
- Keyboard shortcut check for autocomplete
- Copy paste action-based check
- autocomplete suggestions inside strings and comments

#### Issues raised during DP testing

#24025 (comment)
>
>
>
## Checklist:
#### Dev activity
- [x] My code follows the style guidelines of this project
- [x] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [x] My changes generate no new warnings
- [x] I have added tests that prove my fix is effective or that my
feature works
- [x] New and existing unit tests pass locally with my changes
- [ ] PR is being merged under a feature flag


#### QA activity:
- [x] [Speedbreak
features](https://github.com/appsmithorg/TestSmith/wiki/Test-plan-implementation#speedbreaker-features-to-consider-for-every-change)
have been covered
- [x] Test plan covers all impacted features and [areas of
interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans/_edit#areas-of-interest)
- [ ] Test plan has been peer reviewed by project stakeholders and other
QA members
- [x] Manually tested functionality on DP
- [ ] We had an implementation alignment call with stakeholders post QA
Round 2
- [x] Cypress test cases have been added and approved by SDET/manual QA
- [x] Added `Test Plan Approved` label after Cypress tests were reviewed
- [ ] Added `Test Plan Approved` label after JUnit tests were reviewed
@appsmith-bot appsmith-bot added the QA Needs QA attention label Jun 6, 2023
@shwetha-ramesh shwetha-ramesh added Verified When issue is retested post its fixed and removed QA Needs QA attention labels Jul 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Autocomplete Issues related to the autocomplete Bug Something isn't working Javascript Product Issues related to users writing javascript in appsmith Medium Issues that frustrate users due to poor UX Verified When issue is retested post its fixed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants