-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug]-[350]:Random keystrokes trigger autocomplete to show up #15429
Labels
Autocomplete
Issues related to the autocomplete
Bug
Something isn't working
Javascript Product
Issues related to users writing javascript in appsmith
Medium
Issues that frustrate users due to poor UX
Verified
When issue is retested post its fixed
Comments
assuming 5% of autocomplete users face this Stats
|
Aishwarya-U-R
pushed a commit
that referenced
this issue
Jun 6, 2023
## Description PR to fix autocomplete trigger - Disables autocomplete trigger when ctrl/meta/alt is pressed except for (ctrl/meta)+space. - Disable autocomplete inside strings and comments #### PR fixes following issue(s) Fixes #15429 #### Type of change - Bug fix (non-breaking change which fixes an issue) ## Testing > #### How Has This Been Tested? - [x] Manual - [ ] Jest - [x] Cypress > #### Test Plan - Keyboard shortcut check for autocomplete - Copy paste action-based check - autocomplete suggestions inside strings and comments #### Issues raised during DP testing #24025 (comment) > > > ## Checklist: #### Dev activity - [x] My code follows the style guidelines of this project - [x] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [x] I have added tests that prove my fix is effective or that my feature works - [x] New and existing unit tests pass locally with my changes - [ ] PR is being merged under a feature flag #### QA activity: - [x] [Speedbreak features](https://github.com/appsmithorg/TestSmith/wiki/Test-plan-implementation#speedbreaker-features-to-consider-for-every-change) have been covered - [x] Test plan covers all impacted features and [areas of interest](https://github.com/appsmithorg/TestSmith/wiki/Guidelines-for-test-plans/_edit#areas-of-interest) - [ ] Test plan has been peer reviewed by project stakeholders and other QA members - [x] Manually tested functionality on DP - [ ] We had an implementation alignment call with stakeholders post QA Round 2 - [x] Cypress test cases have been added and approved by SDET/manual QA - [x] Added `Test Plan Approved` label after Cypress tests were reviewed - [ ] Added `Test Plan Approved` label after JUnit tests were reviewed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Autocomplete
Issues related to the autocomplete
Bug
Something isn't working
Javascript Product
Issues related to users writing javascript in appsmith
Medium
Issues that frustrate users due to poor UX
Verified
When issue is retested post its fixed
Is there an existing issue for this?
Description
Need to stop showing autocomplete when:
Steps To Reproduce
https://www.loom.com/share/9c22f3e3dd944a8cad11748e2cd1fe31
Public Sample App
No response
Version
Cloud
The text was updated successfully, but these errors were encountered: