Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: Theming :: Selected new Font is reverted whenever Color is removed #15007

Closed
1 task done
Aishwarya-U-R opened this issue Jul 5, 2022 · 1 comment · Fixed by #36119
Closed
1 task done

[Bug]: Theming :: Selected new Font is reverted whenever Color is removed #15007

Aishwarya-U-R opened this issue Jul 5, 2022 · 1 comment · Fixed by #36119
Assignees
@jsartisan @keyurparalkar
Labels
App Theming Product Items that are related to the App level theming controls epic Bug Something isn't working CI impacted Issues that cause CI failures and need to be addressed on priority by respective pods Medium Issues that frustrate users due to poor UX Needs Triaging Needs attention from maintainers to triage Production QA Pod Issues under the QA Pod QA Needs QA attention Widgets & Accelerators Pod Issues related to widgets & Accelerators

Comments

@Aishwarya-U-R
Copy link
Contributor

Is there an existing issue for this?

  • I have searched the existing issues

Description

Screen.Recording.2022-07-05.at.12.16.57.PM.mov

Steps To Reproduce

  1. Create a new App/Page - Select a theme
  2. Observe the Font selected along with selected theme
  3. Now change the 'Font'
  4. Now remove the value from color section to select/update a new value
  5. Observe : Previously selected Font is also removed
  6. Expected: Previous selection should not be removed - be it Font, Color, Shadow, Radius etc on change of any other property

Public Sample App

No response

Version

Prod/Release v1.7.6
@Aishwarya-U-R Aishwarya-U-R added Bug Something isn't working Needs Triaging Needs attention from maintainers to triage App Theming Product Items that are related to the App level theming controls epic Medium Issues that frustrate users due to poor UX labels Jul 5, 2022
@github-actions github-actions bot added the Widgets Product This label groups issues related to widgets label Jul 5, 2022
@dilippitchika
Copy link
Contributor

Very weird behaviour

@jsartisan can you triage this?

@github-actions github-actions bot added Anvil Pod Issue related to Anvil project and removed Widgets Product This label groups issues related to widgets labels Feb 29, 2024
@KelvinOm KelvinOm removed the Anvil Pod Issue related to Anvil project label Mar 28, 2024
@github-actions github-actions bot added the Widgets Product This label groups issues related to widgets label Mar 28, 2024
@yatinappsmith yatinappsmith added the CI impacted Issues that cause CI failures and need to be addressed on priority by respective pods label May 13, 2024
@Nikhil-Nandagopal Nikhil-Nandagopal added Widgets & Accelerators Pod Issues related to widgets & Accelerators and removed Widgets Product This label groups issues related to widgets labels Aug 6, 2024
@jsartisan jsartisan mentioned this issue Sep 4, 2024
Merged
@appsmith-bot appsmith-bot added the QA Needs QA attention label Sep 6, 2024
@github-actions github-actions bot added the QA Pod Issues under the QA Pod label Sep 6, 2024
Shivam-z pushed a commit to Shivam-z/appsmith that referenced this issue Sep 26, 2024
@jsartisan @Shivam-z
fix: Theming Selected new Font is reverted whenever Color is removed (a…
04e87e0 
…ppsmithorg#36119)

Fixes appsmithorg#15007

/ok-to-test tags="@tag.Theme"


<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/10733545727>
> Commit: dec2147
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=10733545727&attempt=1"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.Theme`
> Spec:
> <hr>Fri, 06 Sep 2024 06:48:00 UTC
<!-- end of auto-generated comment: Cypress test results  -->


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

- **New Features**
- Enhanced theme validation for the multi-select widget, improving the
robustness of theme-related tests.
- Added new locators for featured themes to enhance testing
capabilities.

- **Bug Fixes**
- Reactivated a previously skipped test case to validate font
consistency across the application.

- **Refactor**
- Optimized color change handling in the ColorPicker component for
better performance and reliability.
- Refactored theme color control logic for improved maintainability and
clarity.

- **Improvements**
- Enhanced type safety in theme properties to prevent misconfigurations.
- Improved testability of the ThemeCard and ThemeSelector components
with new attributes for automated testing.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->

---------

Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro-2.local>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jsartisan jsartisan

@keyurparalkar keyurparalkar

Labels
App Theming Product Items that are related to the App level theming controls epic Bug Something isn't working CI impacted Issues that cause CI failures and need to be addressed on priority by respective pods Medium Issues that frustrate users due to poor UX Needs Triaging Needs attention from maintainers to triage Production QA Pod Issues under the QA Pod QA Needs QA attention Widgets & Accelerators Pod Issues related to widgets & Accelerators
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Theming Selected new Font is reverted whenever Color is removed appsmithorg/appsmith
8 participants
@Nikhil-Nandagopal @jsartisan @KelvinOm @keyurparalkar @dilippitchika @appsmith-bot @yatinappsmith @Aishwarya-U-R