Skip to content

Commit

Permalink
fix: more action trigger test id added
Browse files Browse the repository at this point in the history
  • Loading branch information
albinAppsmith committed Nov 1, 2024
1 parent d6d98e4 commit fd0f077
Show file tree
Hide file tree
Showing 4 changed files with 4 additions and 3 deletions.
2 changes: 1 addition & 1 deletion app/client/cypress/locators/ApiEditor.js
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ export default {
nameOfApi: ".t--nameOfApi",
ApiNameField: ".t--action-name-edit-field",
addToPageBtn: ".t--addToPageBtn",
ApiActionMenu: "[data-testid=\"more-action-trigger\"]",
ApiActionMenu: "[data-testid=\"t--more-action-trigger\"]",
ApiDeleteBtn: ".t--apiFormDeleteBtn",
ApiRunBtn: "[data-testid=\"t--run-action\"]",
addToPageBtnsId: ".t--addToPageButtons",
Expand Down
2 changes: 1 addition & 1 deletion app/client/cypress/locators/QueryEditor.json
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
"runQuery": "//span[text()='Run']/ancestor::button",
"saveQuery": ".t--save-query",
"deleteQuery": ".t--delete-query",
"queryMoreAction": "[data-testid=more-action-trigger]",
"queryMoreAction": "[data-testid=t--more-action-trigger]",
"deleteUsingContext": ".t--apiFormDeleteBtn",
"addDatasource": ".t--add-datasource",
"editDatasourceButton": ".t--edit-datasource",
Expand Down
2 changes: 1 addition & 1 deletion app/client/cypress/support/Objects/CommonLocators.ts
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ export class CommonLocators {
this._toastMsg + ":contains('" + toastText + "')";
//_specificToast = (toastText: string | RegExp) => this._toastMsg + ":contains("+ (typeof toastText == 'string' ? "'"+ toastText+"'" : toastText)+ ")"//not working!
_empty = "span[name='no-response']";
_contextMenuInPane = "[data-testid='more-action-trigger']";
_contextMenuInPane = "[data-testid='t--more-action-trigger']";
_contextMenuItem = (item: string) =>
"//span[text()='" +
item +
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,7 @@ const PluginActionToolbar = (props: PluginActionToolbarProps) => {
<Menu onOpenChange={toggleMenuOpen} open={isMenuOpen}>
<MenuTrigger>
<Button
data-testid="t--more-action-trigger"
isIconButton
kind="tertiary"
size="sm"
Expand Down

0 comments on commit fd0f077

Please sign in to comment.