Skip to content

Commit

Permalink
chore: add postgres db during the startup conditionally (#37605)
Browse files Browse the repository at this point in the history
## Description
This pull request proposes a change to conditionally add a PostgreSQL
database during startup.

## Automation

/ok-to-test tags="@tag.Sanity"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/12064918747>
> Commit: fbded31
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=12064918747&attempt=1"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.Sanity`
> Spec:
> <hr>Thu, 28 Nov 2024 08:44:27 UTC
<!-- end of auto-generated comment: Cypress test results  -->


## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [ ] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

- **New Features**
- Introduced conditional PostgreSQL service for CI tests, enhancing
database service management.
- **Improvements**
- Refined job conditions for CI tests execution, improving workflow
clarity and control.
- Enhanced error handling and logging for better debugging during test
failures.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
  • Loading branch information
AnaghHegde authored Dec 2, 2024
1 parent 2b64e65 commit 7099113
Showing 1 changed file with 6 additions and 0 deletions.
6 changes: 6 additions & 0 deletions .github/workflows/ci-test-limited.yml
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,13 @@ jobs:
ports:
# Opens tcp port 6379 on the host and service container
- 6379:6379
postgres:
if: github.base_ref == 'pg' || github.ref_name == 'pg'
image: postgres:14
ports:
- 5432:5432
mongo:
if: github.base_ref == 'release' || github.ref_name == 'release'
image: mongo
ports:
- 27017:27017
Expand Down

0 comments on commit 7099113

Please sign in to comment.