Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SE-4161] show download transcript button if no access token present #9

Merged
merged 3 commits into from
Mar 29, 2021
Merged

[SE-4161] show download transcript button if no access token present #9

merged 3 commits into from
Mar 29, 2021

Conversation

gabor-boros
Copy link
Contributor

@gabor-boros gabor-boros commented Mar 21, 2021 •
edited
Loading

This PR extends the download transcripts feature to download the default or selected transcripts for a Wistia video if no API token set for the video in Studio. In case no transcripts are available, the download button won't be shown.

This way it can be ensured that if the API token is set, the users can download all transcripts as one ZIP file, but if no API token set, the default/active transcript can be downloaded anyway.

Dependencies: None

Sandbox URL of the video: video

Screenshots:

Screenshot 2021-03-07 at 20 18 44

Sandbox URL: N/A

Testing instructions:

  1. Start Studio and LMS
  2. Get an access token (https://<YOUR_ACCOUNT>.wistia.com/account/api)
  3. Upload a video with transcript (attached to make it easier, but you can use any video and transcript)
  4. Setup the XBlock as described in the README
  5. Set the API token in the component settings
  6. View the video in LMS
  7. Validate that the transcripts can be downloaded as a ZIP file
  8. Remove the API token
  9. View the video in LMS
  10. Validate the download button is still visible
  11. Download the default/active transcript by clicking the download button
  12. Validate that based on the browser type the transcript is opened in a new tab or downloaded
  13. Remove all transcripts from the video on Wistia
  14. Reload the video and validate no download button is shown

Author notes and concerns:

N/A

Resources

Reviewers

OmarIthawi
OmarIthawi approved these changes Mar 22, 2021
View reviewed changes
Copy link
Contributor

@OmarIthawi OmarIthawi left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @gabor-boros! Please address the changes below and it should be good to merge.

gabor-boros and others added 2 commits March 22, 2021 15:45
@gabor-boros @OmarIthawi
use bool instead of string comparison
5f1a581 
Co-authored-by: Omar Al-Ithawi <i@omardo.com>
@gabor-boros @OmarIthawi
add noopener when opening url
fab1493 
Co-authored-by: Omar Al-Ithawi <i@omardo.com>
@gabor-boros
Copy link
Contributor Author

Thank you @OmarIthawi for the suggestions! Applied them.

@gabor-boros
Copy link
Contributor Author

@OmarIthawi Is there any remaining tasks related to this PR on my side?

@OmarIthawi
Copy link
Contributor

Thanks for the reminder @gabor-boros! I've missed your earlier commit. I'll merge and tag a new version.

@OmarIthawi OmarIthawi merged commit 7818538 into appsembler:master Mar 29, 2021
@OmarIthawi
Copy link
Contributor

Done: https://github.com/appsembler/xblock-wistia/releases/tag/v0.4

@gabor-boros gabor-boros deleted the gabor/show-download-if-no-token-set branch March 29, 2021 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OmarIthawi OmarIthawi OmarIthawi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gabor-boros @OmarIthawi