Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bump to 0.4.1 #415

Merged
merged 1 commit into from
Jan 28, 2022
Merged

bump to 0.4.1 #415

merged 1 commit into from
Jan 28, 2022

Conversation

OmarIthawi
Copy link
Contributor

@OmarIthawi OmarIthawi commented Jan 27, 2022 •
edited
Loading

TODO

  • Get this PR reivewed
  • Merge and release
  • Update edx-configs for both Tahoe staging and prod

@OmarIthawi OmarIthawi requested a review from thraxil January 27, 2022 10:53
@johnbaldwin
Copy link
Contributor

@OmarIthawi Do you want to make this 0.4.0 and be done with the pre-release tags?

@OmarIthawi OmarIthawi changed the title bump to 0.4.dev18 bump to 0.4.1 Jan 28, 2022
@OmarIthawi
bump to 0.4.1
329c865 
I was going to set the version to 0.4.0 but found out:

 - `0.4.0` was released to PyPi in Dec 3, 2020: https://pypi.org/project/Figures/0.4.0/
 - There were not git tag on GitHub

So I "fixed" the situation by:
 - Jumping from 0.4.dev17 to 0.4.1
 - I made a backtracking git 0.4.0 tag on GitHub: https://github.com/appsembler/figures/releases/tag/0.4.0
@OmarIthawi
Copy link
Contributor Author

@OmarIthawi Do you want to make this 0.4.0 and be done with the pre-release tags?

Thanks @johnbaldwin! That's a good time to do it. I've found that 0.4.0 is already used:

So I fixed the situation by:

@OmarIthawi OmarIthawi merged commit 8e219e3 into master Jan 28, 2022
@OmarIthawi OmarIthawi deleted the bump_0.4.dev18 branch January 28, 2022 07:36
@OmarIthawi OmarIthawi mentioned this pull request Jan 28, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bryanlandia bryanlandia bryanlandia approved these changes

@estherjsuh estherjsuh estherjsuh approved these changes

@johnbaldwin johnbaldwin Awaiting requested review from johnbaldwin

@melvinsoft melvinsoft Awaiting requested review from melvinsoft

@shadinaif shadinaif Awaiting requested review from shadinaif

@thraxil thraxil Awaiting requested review from thraxil

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@OmarIthawi @johnbaldwin @bryanlandia @estherjsuh