Fixes serializer tests failing locally in Ginkgo #414
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* The version 2.4.2 `dateutil.parser.parse` method returns a `datetime` object in local time, causing the tests to fail when compared against datetime in UTC * This commit addresses the issue by replacing the timezone with UTC * This commit includes a helper function, `as_datetime_utc` in tests/test_serializers.py * Read the docstring for this helper function
johnbaldwin
requested review from
bryanlandia,
estherjsuh,
melvinsoft,
OmarIthawi and
shadinaif
as code owners
estherjsuh
approved these changes
Jan 26, 2022
bryanlandia
approved these changes
Jan 26, 2022
There was a problem hiding this comment.
Makes sense, but would this function be better put into a test utils module rather than just in this specific serializers test module?
https://github.com/appsembler/figures/search?q=dateutil.parser
shows a lot of files using a dateutil_parse. Maybe at least put this func in test_helpers.py
I'll approve but please consider
|
@bryanlandia I updated per your request |
|
Thanks @johnbaldwin Looks like as_datetime_utc could probably be used here too Line 207 in 95ac4ac |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dateutil.parser.parsemethod returns adatetimeobject in local time, causing the tests to fail when compared against
datetime in UTC
as_datetime_utcin tests/test_serializers.py