Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ginkgo devsite: edx-drf-extensions 0.5.1 for edx-organizations compat #385

Merged
merged 1 commit into from
Jun 28, 2021

Conversation

bryanlandia
Copy link
Contributor

@bryanlandia bryanlandia commented Jun 25, 2021

Change description

Ginkgo devsite was using edx-drf-extensions 1.2.2 as used by edx-platform Ginkgo open-release, which is actually incompatible with the edx-drf-extensions required by edx-organizations 0.4.4. That must have broken install of Ginkgo.
For our use, go with the version required by 0.4.4. The only difference to edx-drf-extensions 1.2.2 is treatment of JWT tokens, which doesn't matter for Figures anyhow.

Allows Ginkgo tests to run via tox -e gingko

Type of change

  • Bug fix (fixes an issue)
  • New feature (adds functionality)

Checklists

Development

  • Lint rules pass locally
  • Application changes have been tested thoroughly
  • Automated tests covering modified code pass

Security

  • Security impact of change has been considered
  • Code follows company security practices and guidelines

Code review

  • Pull request has a descriptive title and context useful to a reviewer. Screenshots or screencasts are attached as necessary
  • "Ready for review" label attached and reviewers assigned
  • Changes have been reviewed by at least one other contributor
  • Pull request linked to task tracker where applicable

@bryanlandia bryanlandia marked this pull request as draft June 25, 2021 20:44
@bryanlandia bryanlandia marked this pull request as ready for review June 25, 2021 20:49
@bryanlandia bryanlandia merged commit 0bbed88 into master Jun 28, 2021
@bryanlandia bryanlandia deleted the bryan/fix-ginkgo-devsite-drf-version-pin branch June 28, 2021 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants